adding support for .svg files in UI logo UI_LOGO param override for admin panel #17898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
justalittleadam
changed the title
# Conflicts: # litellm/proxy/_experimental/out/_next/static/chunks/1200-64d099608f321062.js # litellm/proxy/_experimental/out/_next/static/chunks/2249-985208cb7064c804.js # litellm/proxy/_experimental/out/_next/static/chunks/6609-d93906f43161f066.js # litellm/proxy/_experimental/out/_next/static/chunks/7526-997a4faae4b21df5.js # litellm/proxy/_experimental/out/_next/static/chunks/7641-90e15c72e10330f1.js # litellm/proxy/_experimental/out/_next/static/chunks/766-baf0336e8ba5c686.js # litellm/proxy/_experimental/out/_next/static/chunks/8049-8ef1e898a3048691.js # litellm/proxy/_experimental/out/_next/static/chunks/8093-e09634b69e09143b.js # litellm/proxy/_experimental/out/_next/static/chunks/8143-cd64b2e17d72ff26.js # litellm/proxy/_experimental/out/_next/static/chunks/9878-52c3826c6d453296.js # litellm/proxy/_experimental/out/_next/static/chunks/app/(dashboard)/experimental/api-playground/page-06a63a5f39095f92.js # litellm/proxy/_experimental/out/_next/static/chunks/app/(dashboard)/layout-924e12ba5dd777b7.js # litellm/proxy/_experimental/out/experimental/api-playground.html # litellm/proxy/_experimental/out/experimental/budgets.html # litellm/proxy/_experimental/out/experimental/caching.html # litellm/proxy/_experimental/out/experimental/old-usage.html # litellm/proxy/_experimental/out/experimental/prompts.html # litellm/proxy/_experimental/out/experimental/tag-management.html # litellm/proxy/_experimental/out/login/index.html # litellm/proxy/_experimental/out/mcp/oauth/callback.html # litellm/proxy/_experimental/out/model_hub_table/index.html # litellm/proxy/_experimental/out/models-and-endpoints/index.html # litellm/proxy/_experimental/out/playground/index.html # litellm/proxy/_experimental/out/settings/admin-settings.html # litellm/proxy/_experimental/out/settings/logging-and-alerts.html # litellm/proxy/_experimental/out/settings/router-settings.html # litellm/proxy/_experimental/out/settings/ui-theme.html # litellm/proxy/_experimental/out/test-key/index.html # litellm/proxy/_experimental/out/tools/mcp-servers.html # litellm/proxy/_experimental/out/tools/vector-stores.html # litellm/proxy/_experimental/out/usage/index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Add /ui Logo .svg file support
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🧹 Refactoring
✅ Test
Changes
What this PR changes (SVG logo support)
Adds SVG/SVGZ MIME handling helpers
New litellm/proxy/common_utils/logo_utils.py provides:
infer_logo_content_type() to detect image/svg+xml for .svg / .svgz (and mark .svgz as gzip-encoded).
normalize_logo_content_type() to normalize headers like image/svg → image/svg+xml (and image/jpg → image/jpeg).
cache_extension_for_logo() to choose the right cache filename extension (.svg, .svgz, or a best-effort extension for other image types).
Fixes /get_image to return correct Content-Type for SVG
In litellm/proxy/proxy_server.py, /get_image now:
Returns media_type="image/svg+xml" for local UI_LOGO_PATH pointing to .svg/.svgz instead of always image/jpeg.
For remote logos (HTTP/HTTPS), reads Content-Type from the response when present, otherwise infers it from the URL path.
Caches remote logos using the correct extension (cached_logo.svg / cached_logo.svgz), rather than always writing cached_logo.jpg.
Preserves Content-Encoding: gzip when serving .svgz (so browsers can decode it correctly).
Adds tests for the new behavior
In tests/test_litellm/proxy/test_proxy_server.py, adds mocked tests that verify:
Local Unit Test Passing:
Full file run:
Specific unit test added passing:
Evidence of the Update:
Before SVG ui Handling (overriding UI_LOGO param with a link to a local .svg):
After Svg Handling: (the purple circular "LLM" image).
A NOTE TO REVIEWER:
Locally, linting failed with
I also witnessed this happen in your automation pipeline, as well as running linting in a direct clone from main. I do not believe this failure is related to my change, but, rather, something else in the codebase.
also, locally running format updated around 673 files. I did not change those 673 files. i witnessed the same behavior when comparing in main. running make format in main resulted in the same (673) files reformatted. Again, i dont believe this is related to my change.
Additionally, i am noticing the custom prompt management unit tests are failing.
Primary commit to review:
8bbe112