views: Items#show: Use <DL/> for item info #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awilfox
force-pushed
the
awilfox/ADA-399
branch
from
80f9813 to
6dcac17
Compare
anarchivist
approved these changes
Dec 2, 2025
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
looks good; one potential suggestion.
This replaces the odd collection of form-group <DIV/>s with H5 titles. Now we use a <DL/>. This is not only more accessible, but clearer in both semantic meaning and a nicer UX. Fixes: ADA-399
awilfox
force-pushed
the
awilfox/ADA-399
branch
from
6dcac17 to
a4bd869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the odd collection of form-group
<DIV/>s with H5 titles. Now we use a<DL/>. This is not only more accessible, but clearer in both semantic meaning and a nicer UX.Fixes: ADA-399