Skip to content

Conversation

@awilfox
Copy link
Member

@awilfox awilfox commented May 27, 2025

For debugging and security response, we need to be able to know the original requestor's IP, not just the Traefik IP handling the request. This adds the content of the X-Forwarded-For header to the combined LogFormat, which is what we pipe out.

If there is no content, Apache will log a "-"; there is no impact to images that directly face the Internet without being behind a proxy.

For debugging and security response, we need to be able to know the
original requestor's IP, not just the Traefik IP handling the request.
This adds the content of the X-Forwarded-For header to the combined
LogFormat, which is what we pipe out.

If there is no content, Apache will log a "-"; there is no impact to
images that directly face the Internet without being behind a proxy.
@awilfox awilfox requested a review from jaysundu May 27, 2025 16:46
Copy link
Contributor

@jaysundu jaysundu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@awilfox awilfox merged commit 439e7e5 into main May 27, 2025
4 checks passed
@awilfox awilfox deleted the DEV-917-add-XFF-to-log branch May 27, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants