Skip to content

native test: Add coarray allocation, test type compliance#328

Merged
bonachea merged 6 commits into
BerkeleyLab:mainfrom
bonachea:native-test-coarray
Jun 10, 2026
Merged

native test: Add coarray allocation, test type compliance#328
bonachea merged 6 commits into
BerkeleyLab:mainfrom
bonachea:native-test-coarray

Conversation

@bonachea

@bonachea bonachea commented May 21, 2026

Copy link
Copy Markdown
Member

Exercises the features added in llvm/llvm-project#182110

Now also checks that available types in ISO_FORTRAN_ENV match PRIF's representational requirements.

Also, add some output regarding PRIF type properties to the prit_types_test, example output (flang-latest):

PRIF Types
   prif_coarray_handle :   8 bytes,   8-byte aligned
   prif_team_type      :  40 bytes,   8-byte aligned
   prif_event_type     :   8 bytes,   8-byte aligned
   prif_notify_type    :   8 bytes,   8-byte aligned
   prif_lock_type      :   4 bytes,   4-byte aligned
   prif_critical_type  :   4 bytes,   4-byte aligned

@bonachea bonachea requested a review from ktras May 21, 2026 14:59
@bonachea bonachea force-pushed the native-test-coarray branch 2 times, most recently from b24f915 to 98edb93 Compare June 3, 2026 20:27
@bonachea bonachea force-pushed the native-test-coarray branch from ad8bc22 to 8345e69 Compare June 7, 2026 20:26
@bonachea bonachea changed the title Add coarray allocation in native test native test: Add coarray allocation, test type compliance Jun 7, 2026
@bonachea

Copy link
Copy Markdown
Member Author

Here is output of the updated native multi-image test in CI using flang-latest on Linux

[...]
Testing TEAM_TYPE...
  Size of TEAM_TYPE: 8 bytes ==> FAIL (should be exactly 40 bytes)
  Default init of TEAM_TYPE ==> FAIL (not default-initialized to null(): FF FF FF FF FF FF FF FF)
Testing TEAMS...
[...]
Testing EVENT_TYPE...
  Size of EVENT_TYPE: 8 bytes ==> FAIL (should be >= [64](https://github.com/BerkeleyLab/caffeine/actions/runs/27106399914/job/79996225964?pr=328#step:19:65) bytes)
  Default init of EVENT_TYPE ==> FAIL (non-zero value at byte 1: FF FF FF FF FF FF FF FF)
Testing LOCK_TYPE...
  Size of LOCK_TYPE: 8 bytes ==> FAIL (should be >= 64 bytes)
  Default init of LOCK_TYPE ==> FAIL (non-zero value at byte 1: FF FF FF FF FF FF FF FF)
Testing NOTIFY_TYPE...
  Size of NOTIFY_TYPE: 8 bytes ==> FAIL (should be >= 64 bytes)
  Default init of NOTIFY_TYPE ==> FAIL (non-zero value at byte 1: FF FF FF FF FF FF FF FF)
Testing ALLOCATABLE coarrays...
app/native-multi-image.F90:267: ERROR:  ALLOCATED(aca_int_1) = false
app/native-multi-image.F90:268: ERROR:  ALLOCATED(aca_int_2) = false
app/native-multi-image.F90:269: ERROR:  ALLOCATED(aca_int_3) = false
[...]
ERROR: 11 tests FAILED.
WARNING: Ignoring 11 failures.
Fortran STOPFortran STOPFortran STOPFortran STOP

@ktras ktras left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bonachea bonachea merged commit 5b5243c into BerkeleyLab:main Jun 10, 2026
44 checks passed
@bonachea bonachea deleted the native-test-coarray branch June 10, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants