Add trivial implementation for prif_fail_image#289
Merged
bonachea merged 4 commits intoBerkeleyLab:mainfrom Jan 28, 2026
Merged
Add trivial implementation for prif_fail_image#289bonachea merged 4 commits intoBerkeleyLab:mainfrom
prif_fail_image#289bonachea merged 4 commits intoBerkeleyLab:mainfrom
Conversation
ktras
approved these changes
Jan 27, 2026
Collaborator
ktras
left a comment
ktras
left a comment
There was a problem hiding this comment.
LGTM but I have a suggested improvement to an inline code comment.
This provides a trivial implementation of prif_fail_image() that just hangs the calling image forever (unless it is the only image, in which case it just terminates). This is "trivial" in the sense that other images never directly learn that another image has failed, but it is nevertheless believed to be standards-conforming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a trivial implementation of
prif_fail_image()that just hangs the calling image forever (unless it is the only image, in which case it just terminates). This is "trivial" in the sense that other images never directly learn that another image has failed, but it is nevertheless believed to be standards-conforming.