Release 1.0.5#12
Merged
Merged
Conversation
onTeamKick and onTeamLeave had inverted boolean logic: they called resize() whenever the kicked/leaving island was NOT in StrangerRealms' own world, so any /<gamemode> team kick or leave on the server would fire resize() on the wrong addon's island. resize() then called Island.setRange() with StrangerRealms' configured distance (typically 64 with defaults: 32 + 32*(members-1)), overwriting the range field of e.g. AOneBlock, BSkyBlock, Boxed islands. On the next server restart IslandsManager.load() refused to load those islands because range no longer matched the configured distance-between-islands and BentoBox panic-disabled with "Island distance mismatch". Invert the conditions to early-return when the island isn't in StrangerRealms' world (matching the pattern already used in onTeamJoin) and add a defensive guard at the top of resize() so any future listener bug can't reintroduce the same corruption. Includes a TeamListenerTest regression suite. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ther-gamemode-islands Fix TeamListener corrupting range on other game modes' islands
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.