Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8.3.0
9.0.0
2 changes: 1 addition & 1 deletion .bcr/presubmit.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
bcr_test_module:
module_path: "e2e/smoke"
matrix:
platform: ["debian10", "macos", "ubuntu2004", "windows"]
platform: ["debian10", "macos_arm64", "ubuntu2004", "windows"]
tasks:
run_tests:
name: "Run test module"
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
bzlmod: [true]
bazel_version: ["7.4.1", "8.0.1"]
bazel_version: ["8.x", "9.x"]
runs-on: ${{ matrix.os }}
steps:
- name: "Checkout the sources"
Expand All @@ -39,15 +38,14 @@ jobs:
- name: "Running tests //..."
env:
USE_BAZEL_VERSION: ${{ matrix.bazel_version }}
run: bazel test //... --enable_bzlmod=${{ matrix.bzlmod }}
run: bazel test //...
integration-tests:
strategy:
matrix:
os: [ubuntu-latest]
bzlmod: [true]
directory: [examples/simple-android]
strategy: [local, worker]
bazel_version: ["7.4.1", "8.0.1"]
bazel_version: ["8.x", "9.x"]
runs-on: ${{ matrix.os }}
steps:
- name: "Checkout the sources"
Expand All @@ -65,4 +63,4 @@ jobs:
env:
USE_BAZEL_VERSION: ${{ matrix.bazel_version }}
working-directory: ${{ matrix.directory }}
run: bazel test //... --enable_bzlmod=${{ matrix.bzlmod }} --strategy=AndroidLint=${{ matrix.strategy }}
run: bazel test //... --strategy=AndroidLint=${{ matrix.strategy }}
21 changes: 11 additions & 10 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,18 @@ module(
compatibility_level = 1,
)

bazel_dep(name = "rules_android", version = "0.6.1")
bazel_dep(name = "rules_java", version = "8.6.3")
bazel_dep(name = "rules_jvm_external", version = "6.7")
bazel_dep(name = "rules_kotlin", version = "2.1.0")
bazel_dep(name = "bazel_skylib", version = "1.7.1")
bazel_dep(name = "platforms", version = "0.0.8")
bazel_dep(name = "bazel_worker_api", version = "0.0.4")
bazel_dep(name = "bazel_worker_java", version = "0.0.4")
bazel_dep(name = "rules_android", version = "0.7.1")
bazel_dep(name = "rules_java", version = "9.3.0")
bazel_dep(name = "rules_jvm_external", version = "6.9")
bazel_dep(name = "rules_kotlin", version = "2.2.2")
bazel_dep(name = "rules_python", version = "1.7.0")
bazel_dep(name = "bazel_skylib", version = "1.9.0")
bazel_dep(name = "platforms", version = "1.0.0")
bazel_dep(name = "bazel_worker_api", version = "0.0.10")
bazel_dep(name = "bazel_worker_java", version = "0.0.10")

bazel_dep(name = "aspect_bazel_lib", version = "2.11.0", dev_dependency = True)
bazel_dep(name = "buildifier_prebuilt", version = "8.0.0", dev_dependency = True)
bazel_dep(name = "aspect_bazel_lib", version = "2.22.5", dev_dependency = True)
bazel_dep(name = "buildifier_prebuilt", version = "8.2.1.2", dev_dependency = True)

register_toolchains("//toolchains:android_lint_default_toolchain")

Expand Down
2 changes: 1 addition & 1 deletion e2e/smoke/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
bazel_dep(name = "rules_android_lint", version = "0.0.0", dev_dependency = True)
bazel_dep(name = "bazel_skylib", version = "1.7.1", dev_dependency = True)
bazel_dep(name = "bazel_skylib", version = "1.9.0", dev_dependency = True)

local_path_override(
module_name = "rules_android_lint",
Expand Down
20 changes: 1 addition & 19 deletions e2e/smoke/WORKSPACE.bazel
Original file line number Diff line number Diff line change
@@ -1,19 +1 @@
# Override http_archive for local testing
local_repository(
name = "rules_android_lint",
path = "../..",
)

#---SNIP--- Below here is re-used in the workspace snippet published on releases

######################
# rules_android_lint setup #
######################
# Fetches the rules_android_lint dependencies.
# If you want to have a different version of some dependency,
# you should fetch it *before* calling this.
# Alternatively, you can skip calling this function, so long as you've
# already fetched all the dependencies.
load("@rules_android_lint//android_lint:repositories.bzl", "rules_android_lint_dependencies")

rules_android_lint_dependencies()
# Marker file for Bazel workspace root
2 changes: 0 additions & 2 deletions e2e/smoke/WORKSPACE.bzlmod

This file was deleted.

1 change: 0 additions & 1 deletion examples/simple-android/.bazelrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
common --enable_bzlmod
common --lockfile_mode=off
common --experimental_google_legacy_api
test --test_output=all
6 changes: 3 additions & 3 deletions examples/simple-android/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ local_path_override(
)

bazel_dep(name = "platforms", version = "1.0.0")
bazel_dep(name = "rules_android", version = "0.6.5")
bazel_dep(name = "rules_jvm_external", version = "6.7")
bazel_dep(name = "rules_android", version = "0.7.1")
bazel_dep(name = "rules_jvm_external", version = "6.9")

remote_android_extensions = use_extension(
"@rules_android//bzlmod_extensions:android_extensions.bzl",
"remote_android_tools_extensions",
)
use_repo(remote_android_extensions, "android_gmaven_r8", "android_tools")
use_repo(remote_android_extensions, "android_tools")

android_sdk_repository_extension = use_extension("@rules_android//rules/android_sdk_repository:rule.bzl", "android_sdk_repository_extension")
use_repo(android_sdk_repository_extension, "androidsdk")
Expand Down
1 change: 1 addition & 0 deletions examples/simple-android/WORKSPACE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Marker file for Bazel workspace root
Empty file.
12 changes: 6 additions & 6 deletions maven_install.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"__AUTOGENERATED_FILE_DO_NOT_MODIFY_THIS_FILE_MANUALLY": "THERE_IS_NO_DATA_ONLY_ZUUL",
"__INPUT_ARTIFACTS_HASH": 1552138821,
"__RESOLVED_ARTIFACTS_HASH": 419430451,
"__INPUT_ARTIFACTS_HASH": 1120496732,
"__RESOLVED_ARTIFACTS_HASH": 1645161352,
"artifacts": {
"com.android.tools.analytics-library:protos": {
"shasums": {
Expand Down Expand Up @@ -143,9 +143,9 @@
},
"com.google.code.gson:gson": {
"shasums": {
"jar": "4241c14a7727c34feea6507ec801318a3d4a90f070e4525681079fb94ee4c593"
"jar": "0cdd163ce3598a20fc04eee71b140b24f6f2a3b35f0a499dbbdd9852e83fbfaf"
},
"version": "2.10.1"
"version": "2.10"
},
"com.google.errorprone:error_prone_annotations": {
"shasums": {
Expand All @@ -161,9 +161,9 @@
},
"com.google.guava:guava": {
"shasums": {
"jar": "12429ff9ac33b7afd8b1a5071179757cf4d3c47f0f4099bc0384e644ecbf82dd"
"jar": "bd7fa227591fb8509677d0d1122cf95158f3b8a9f45653f58281d879f6dc48c5"
},
"version": "32.0.1-android"
"version": "32.0.1-jre"
},
"com.google.guava:listenablefuture": {
"shasums": {
Expand Down
3 changes: 1 addition & 2 deletions rules/android_lint.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ android_lint = rule(
implementation = _impl,
attrs = _dicts.add(
_ATTRS,
dict(
),
dict(),
),
provides = [
_AndroidLintResultsInfo,
Expand Down
14 changes: 10 additions & 4 deletions rules/repositories.bzl
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
"""Declare runtime dependencies
"""Declare runtime dependencies.

Dependencies are declared in MODULE.bazel via Bzlmod.
"""

# buildifier: disable=unnamed-macro
def android_lint_register_toolchains():
def android_lint_register_toolchains(name = "android_lint_toolchains"):
"""Convenience macro for users which does typical setup.

This registers the default android_lint toolchain.

Args:
name: Name for this macro invocation (unused, required by convention).
"""
pass
native.register_toolchains("@rules_android_lint//toolchains:android_lint_default_toolchain")
2 changes: 2 additions & 0 deletions src/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
load("@rules_python//python:defs.bzl", "py_binary")

py_binary(
name = "android_lint_output_validator",
srcs = ["android_lint_output_validator.py"],
Expand Down
Loading