refactor: renamed package geocoding_ios to geocoding_darwin#278
Closed
OutdatedGuy wants to merge 7 commits intoBaseflow:mainfrom
OutdatedGuy:refactor/rename-to-darwin
Closed
refactor: renamed package geocoding_ios to geocoding_darwin#278OutdatedGuy wants to merge 7 commits intoBaseflow:mainfrom OutdatedGuy:refactor/rename-to-darwin
OutdatedGuy wants to merge 7 commits intoBaseflow:mainfrom
OutdatedGuy:refactor/rename-to-darwin
Conversation
Member
|
Hi @OutdatedGuy, Recently we have started refactoring the platform interface package and I have a PR open (see #278). As part of this I have also already created a Darwin implementation based on the new interface (PR will be published soon). I expect to land these PRs soon as they offer more finegrained control and resolve several other issues reported and supports the new Unfortunately this means this PR becomes obsolete, which pains me to say as you've put a considerable amount of time into it. |
Contributor
Author
|
No worries as long as the plugin is maintained and gets macOS support. Thanks for the update @mvanbeusekom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
geocoding_iostogeocoding_darwinto later add macOS support. Will follow up with macOS support PR after this is merged.resolves #244
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.