feat add processing conversation on desktop#4607
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a widget to display conversations that are currently being processed on the desktop version of the application. The implementation is clean and integrates well with the existing conversation list. I have one suggestion to improve the new widget by making it display dynamic data instead of being a static placeholder, which also resolves an unused parameter issue.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Hey @krushnarout, sorry about the delay on this — @beastoin doesn't have bandwidth to review it right now and doesn't have any plans to in the near future. @aaravgarg, could you take a look and make the call on this one? Feel free to approve and merge if it looks good to you. Thanks both! |
|
Hey @krushnarout 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! 💜 |
|
This was delegated for review but the reviewer never followed up, and it was silently closed without explanation. That's a process gap on our end. If you'd like to resubmit, we'll make sure it gets a proper review. |
|
Hey @krushnarout — thanks for this contribution, and sorry again for the delegation gap on our end. You submitted this, it was delegated for review, the reviewer never followed up, and then it was closed without explanation. That's entirely on us. We've now reviewed the full diff and wanted to share feedback: What's good:
Items that need attention: 1. Visibility gap in empty-history state (high) 2. Widget doesn't use the conversation data (medium) 3. No test coverage (low) Path forward: Thanks for contributing to Omi. |
|
@krushnarout Some pointers on the items mentioned above: Empty-history visibility: The processing widget is inside the sliver list that only renders when Using real conversation data: The widget currently accepts a Review ownership: If you resubmit, we'll assign a specific reviewer upfront — no more delegation gaps. Let us know if you'd like to pick this back up. |
|
Hey @krushnarout 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! 💜 |
Uh oh!
There was an error while loading. Please reload this page.