Merged
Conversation
- Update default page font from monospace to Outfit (sans-serif) for better readability - Add enable_etags config flag to make ETag generation optional (default: true) - Update CheckNotModified() to respect the enable_etags setting - Update SetCacheHeaders() to conditionally set ETag headers - Add comprehensive tests for ETag feature flag behavior - Update config.toml.example with new enable_etags setting and documentation
Embedded assets (style.css, index.html, 404.html) served via serveEmbedded() and serveNotFound() were missing ETag, Cache-Control, and Vary headers, preventing conditional request (304) support. Both paths now emit the same caching headers as the regular disk/cache path, respecting the enable_etags config flag. Three new tests cover ETag on/off and Cache-Control max-age for the embedded path. Landing page updated to reflect full ETag coverage across all assets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.