Set Windows SDK Target Version in build scripts#508
Closed
CedricGuillemet wants to merge 2 commits intoBabylonJS:masterfrom
Closed
Set Windows SDK Target Version in build scripts#508CedricGuillemet wants to merge 2 commits intoBabylonJS:masterfrom
CedricGuillemet wants to merge 2 commits intoBabylonJS:masterfrom
Conversation
CedricGuillemet
changed the title
ryantrem
reviewed
Dec 5, 2022
Comment on lines
+128
to
+136
| let WindowsSDKVersionCMakeString = ""; | ||
| const [WindowsSDKVersionFlag] = process.argv.slice(3); | ||
| if (WindowsSDKVersionFlag === '-WindowsSDKVersion') { | ||
| const [WindowsSDKVersionValue] = process.argv.slice(4); | ||
| if (WindowsSDKVersionValue) | ||
| { | ||
| WindowsSDKVersionCMakeString = `-DCMAKE_SYSTEM_VERSION=${WindowsSDKVersionValue}`; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Would it make more sense to put this logic in tools.js (which I just noticed we have duplicated between RN versions 😬) and invoked via an npm script in package.json? This would be more like what we do for iOS, which makes it really easy to do locally in an isolated way.
Contributor
Author
There was a problem hiding this comment.
I'm not sure. tools.js is used to build the PG. and gulp.js is used to build packages. moreover, you can test this change locally with npx gulp buildUWPPublish -WindowsSDKVersion 10.0....
Contributor
Author
|
fixed with #665 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build Script var to set Windows SDK version