Merged
Conversation
…into BRNSourceTree
There was a problem hiding this comment.
Pull request overview
This PR adds a new CMake build flag BABYLON_NATIVE_BUILD_SOURCETREE to conditionally bypass the Android-only build restriction in the AndroidExtensions project. This is part of ongoing work related to BabylonReactNative PR #665.
Changes:
- Modified the Android platform check to allow builds for non-Android platforms when
BABYLON_NATIVE_BUILD_SOURCETREEflag is set
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -17,7 +17,7 @@ FetchContent_MakeAvailable(CMakeExtensions) | |||
|
|
|||
| project(AndroidExtensions) | |||
|
|
|||
There was a problem hiding this comment.
The flag BABYLON_NATIVE_BUILD_SOURCETREE is not documented anywhere in the codebase. Consider adding documentation or comments explaining what this flag is for, when it should be used, and what platforms are supported when it's enabled. This will help other developers understand the purpose and proper usage of this build configuration.
Suggested change
| # BABYLON_NATIVE_BUILD_SOURCETREE is an internal flag used when this project is | |
| # built as part of the Babylon Native source tree (for example, via the parent | |
| # Babylon Native CMake build). In that scenario, the outer build system controls | |
| # the target platforms and toolchains, so we allow configuration even when the | |
| # CMake ANDROID variable is not set. | |
| # | |
| # When building AndroidExtensions standalone (i.e., not from within the Babylon | |
| # Native source tree), this flag should normally remain unset, and the project is | |
| # intended to build only for Android. In that case, we enforce the Android-only | |
| # restriction with the check below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to BabylonJS/BabylonReactNative#665