#1 Remove the activemodel dependency #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldevries
changed the title
danieldevries
force-pushed
the
remove-activemodel-dependency
branch
3 times, most recently
from
f545232 to
e63ad3e
Compare
We used it for casting the value to a defined type, but since we only support simple types like integers and strings, we can better use things like #to_i and #to_s. The other data type we support are other classes that include JsonPathAttribute, so we can call .parse on those with the parsed values.
danieldevries
force-pushed
the
remove-activemodel-dependency
branch
from
e63ad3e to
c8f0246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used it for casting the value to a defined type, but since we only support simple types like integers and strings, we can better use things like #to_i and #to_s.
The other data type we support are other classes that include JsonPathAttribute, so we can call .parse on those with the parsed values.