Implemented Service Exception for Imds Probe #5615
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
approved these changes
Dec 9, 2025
gladjohn
approved these changes
Dec 9, 2025
bgavrilMS
reviewed
Dec 12, 2025
| { | ||
| requestContext.Logger.Info($"[Managed Identity] {imdsStringHelper} probe endpoint failure. Exception occurred while sending request to probe endpoint: {ex}"); | ||
| return false; | ||
| throw new MsalServiceException( |
Member
There was a problem hiding this comment.
How about this:
- Let cancellation exceptions pass through
- Capture the messages why IMDS1 and IMDS2 probe failed and output them when app calls AcquireToken() . Smth like "Cannot acquire a token for managed identity. IMDSv1 discovery failed with xyz and IMDSv2 discovery failed with bar"
Member
There was a problem hiding this comment.
@christothes - do you need the new GetSourceAsync API to also return to you why IMDSv1 and IMDSv2 probes failed when we return Source.None ?
There was a problem hiding this comment.
If we are able to pass the failure reason back to the caller, it would be better to have it at GetSourceAsync than at GetToken. For DefaultAzureCredential, it will determine if we skip managed identity alltogether.
Member
There was a problem hiding this comment.
Sounds good, let's return an object then @Robbie-Microsoft that has the enum and the failures of IDMSv2 and IMDSv1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also fix the flaky test related to Imds Probe Cancellation Token
Fixes #5565