-
Notifications
You must be signed in to change notification settings - Fork 297
Added documentation for DAB MCP and AI Foundry integration setup. #2971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive documentation for integrating Data API Builder (DAB) Model Context Protocol (MCP) server with Azure AI Foundry using Azure Container Instances.
Key Changes:
- New end-to-end integration guide covering architecture, prerequisites, and deployment steps
- Documentation of DAB container deployment to Azure Container Instances with MCP endpoint configuration
- Instructions for connecting Azure AI Foundry agents to DAB MCP endpoints
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RubenCerna2079
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add some instructions under step 5
|
step No. 6 is missing in the diagram. |
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve the comments
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
A file share is just one component of a Storage Account, similar to how a bucket functions in S3. Including it in the diagram would add unnecessary detail and clutter, so I intentionally left it out. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
RubenCerna2079
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
This is still not fixed: |
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming the rest of the minor comments will be resolved.
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
I addressed it Ani. Did not change the diagram, as it will make the diagram really crowded and File share is not a new service is Azure it is like a bucket in S3. I did not feel it is right to add it as an entity in the diagram, as all other entities in the diagrams are existing azure services or service which we built. |
|
@anushakolan I've opened a new pull request, #3033, to work on those changes. Once the pull request is ready, I'll request review from you. |
Re-ordered the structure of config file.
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Why make this change?
This change adds documented instructions on integrating the DAB MCP with AI Foundry using an Azure Container Instance.