Skip to content

Conversation

@anushakolan
Copy link
Contributor

@anushakolan anushakolan commented Nov 13, 2025

Why make this change?

This change adds documented instructions on integrating the DAB MCP with AI Foundry using an Azure Container Instance.

image

@anushakolan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation for integrating Data API Builder (DAB) Model Context Protocol (MCP) server with Azure AI Foundry using Azure Container Instances.

Key Changes:

  • New end-to-end integration guide covering architecture, prerequisites, and deployment steps
  • Documentation of DAB container deployment to Azure Container Instances with MCP endpoint configuration
  • Instructions for connecting Azure AI Foundry agents to DAB MCP endpoints

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@RubenCerna2079 RubenCerna2079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add some instructions under step 5

@Aniruddh25
Copy link
Collaborator

step No. 6 is missing in the diagram.

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the comments

anushakolan and others added 4 commits December 20, 2025 00:57
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
anushakolan and others added 4 commits December 20, 2025 00:58
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@anushakolan
Copy link
Contributor Author

anushakolan commented Dec 20, 2025

step No. 6 is missing in the diagram.

A file share is just one component of a Storage Account, similar to how a bucket functions in S3. Including it in the diagram would add unnecessary detail and clutter, so I intentionally left it out.

@anushakolan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@anushakolan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Contributor

@RubenCerna2079 RubenCerna2079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aniruddh25
Copy link
Collaborator

This is still not fixed:

#2971 (comment)

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming the rest of the minor comments will be resolved.

anushakolan and others added 2 commits December 22, 2025 15:32
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
@anushakolan
Copy link
Contributor Author

This is still not fixed:

#2971 (comment)

I addressed it Ani. Did not change the diagram, as it will make the diagram really crowded and File share is not a new service is Azure it is like a bucket in S3. I did not feel it is right to add it as an entity in the diagram, as all other entities in the diagrams are existing azure services or service which we built.

Copy link
Contributor

Copilot AI commented Dec 22, 2025

@anushakolan I've opened a new pull request, #3033, to work on those changes. Once the pull request is ready, I'll request review from you.

Re-ordered the structure of config file.
@anushakolan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@anushakolan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants