-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Enable A365 tracing and fix W3C baggage propagation in agentserver #46754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
singankit
wants to merge
47
commits into
main
Choose a base branch
from
feature/enable-a365-tracing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
5f81dca
Enable A365 tracing in agentserver-core when hosted
singankit 0392a27
Add agent_id, blueprint_id, and tenant_id resolution to tracing enric…
singankit 8db62c6
Enable a365_enable_observability_exporter in A365 tracing config
singankit d8bb33e
Add a365_observability_scope_override to A365 tracing config
singankit a0c1637
Fix streaming context: capture full context (span + baggage) for iter…
singankit 046cc7b
Fix baggage propagation: extract only W3C baggage from request headers
singankit aee8584
Fix W3C baggage propagation in invocations and add tests for both pac…
singankit 167bd4a
Fix test: remove assertion for server-added baggage at span start time
singankit ce9ae4f
Fix test: use correct span name 'invoke_agent' instead of 'create_res…
singankit dab1c87
Fix invocations test: remove assertion for server-added baggage at sp…
singankit 078502d
Add bkey/bval to local cspell ignore lists
singankit 3cda909
Remove unused imports detach_context and set_current_span
singankit d9d5982
Add enable_sensitive_data param to configure_observability
singankit 36b9d38
Fix test assertions to include enable_sensitive_data param
singankit 0a1e5ec
Add microsoft.foundry.agent.type attribute scoped to invoke_agent spans
singankit 0c0eea7
Remove invoke_agent SERVER span, keep W3C context propagation
singankit b9c187c
Add proper span parenting test for responses package
singankit 7410482
Bump azure-ai-agentserver-core min dependency to >=2.0.0b4
singankit 21e8641
Make request_context backward-compatible with core 2.0.0b3
singankit 69b2660
Add e2e span parenting test with real caller span
singankit baf6478
Stamp invocation_id on spans via FoundryEnrichmentSpanProcessor and a…
singankit dff280f
Fix CI test failures: prevent OTel distro from contaminating global s…
singankit 5857a8b
fix: use inject(headers) in traceparent test for CI reliability
singankit 400d271
refactor: use OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT for …
singankit 871e203
fix: use inject(headers) in invocations traceparent tests for CI reli…
singankit 4290e21
Fix test_incoming_baggage_stamped_on_handler_spans for CI
singankit 8047e3f
Merge origin/main into feature/enable-a365-tracing
singankit 61e3a0e
Fix pylint errors: line-too-long and unused imports
singankit 7ff6248
Simplify request_context() and add debug logging
singankit 58806dc
Fix debug log: use get_current_span() instead of non-existent get_spa…
singankit 6faa575
debug: log raw trace headers and full post-attach span context
singankit dd97f34
debug: create SERVER span in request_context for downstream instrumen…
singankit c19a4a7
debug: test span without explicit parent context
singankit 422eb1d
debug: re-enable context=ctx on blah span to parent under remote trace
singankit dcbb745
feat: add Starlette OTel instrumentation for automatic HTTP SERVER spans
singankit 9b7ee76
refactor: replace request_context with BaggageMiddleware + Starlette …
singankit 7939515
Suppress noisy ASGI receive/send internal spans
singankit 9db26d2
Test: remove BaggageMiddleware to isolate NonRecordingSpan crash
singankit 55698eb
Replace Starlette instrumentor with TraceContextMiddleware
singankit c76059f
Fix TraceContextMiddleware: use opentelemetry.propagate.extract
singankit 51b7c7b
Remove unused opentelemetry-instrumentation-starlette dependency
singankit 7d73600
Fix pylint: trailing newline and unused contextlib import
singankit 4d6e1e9
Fix E2E tracing test: skip distro mock when running with -m tracing_e2e
singankit c7dae15
Fix core E2E tests: remove request_context() calls
singankit 7d116bf
Fix E2E test: use get_span_context() instead of .context
singankit c40da1b
Add E2E test: framework spans emitted without incoming trace context
singankit 3fcfcbf
Use span_id and trace_id to validate span in App Insights
singankit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All env variables needs to be added to the spec https://github.com/coreai-microsoft/foundrysdk_specs/blob/main/specs/agents/hosted_agents/container-spec/docs/container-image-spec.md