[Python] TypeSpec migration for azure-mgmt-billingbenefits#45961
Draft
msyyc wants to merge 3 commits intoAzure:mainfrom
Draft
[Python] TypeSpec migration for azure-mgmt-billingbenefits#45961msyyc wants to merge 3 commits intoAzure:mainfrom
msyyc wants to merge 3 commits intoAzure:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Python] TypeSpec migration for azure-mgmt-billingbenefits
Spec Source
TypeSpec folder: specification/billingbenefits/BillingBenefits.Management
Pre-migration Source
Pre-migration swagger: specification/billingbenefits/resource-manager@2b47198d
Swagger API version:
2024-11-01-preview(default tag:package-preview-2024-11-01-preview)Generated with apiVersion:
2025-12-01-preview(latest in TypeSpec enum Versions)Breaking Change Analysis
5 mitigated | 37 accepted
Mitigated (in spec PR: Azure/azure-rest-api-specs#41833)
BillingBenefitsRPdeleted@@clientName(Microsoft.BillingBenefits, "BillingBenefitsRP", "python")BillingPlan.P1_Mrenamed@@clientName(BillingPlan.P1M, "P1_M", "python")Term.P1_Yrenamed@@clientName(Term.P1Y, "P1_Y", "python")Term.P3_Yrenamed@@clientName(Term.P3Y, "P3_Y", "python")Term.P5_Yrenamed@@clientName(Term.P5Y, "P5_Y", "python")Accepted Breaking Changes (37)
Property flattening removal (22 changes):
Discountproperties (entity_type,product_code,start_at,system_id,provisioning_state,billing_account_resource_id,billing_profile_resource_id,customer_resource_id,display_name,status,benefit_resource_id,applied_scope_type) moved under.propertiesSavingsPlanOrderAliasModelproperties (display_name,savings_plan_order_id,provisioning_state,billing_scope_id,term,billing_plan,applied_scope_type,applied_scope_properties,commitment,renew) moved under.propertiesPageable model removal (3 changes):
DiscountList,SavingsPlanModelList,SavingsPlanOrderModelList— Python SDK uses iterators, doesn't expose paging wrapper modelsUnreferenced/new-API-version models (7 changes):
AppliedDiscount,BillingInformation,DiscountProvisioningSubState,OperationResultError,PricingCurrencyDuration,PricingCurrencyTotal,SavingsPlanPurchaseValidateRequest— Models either unreferenced from operations or restructured between API versionsCommon types upgrade (1 change):
ResourceModelWithAllowedPropertySet— Legacy ARM common type not present in TypeSpecParameter kind change (5 changes):
SavingsPlanOperations.list_allparametersorderby,refresh_summary,skiptoken,selected_state,takechanged from positional to keyword-only (Python SDK generator improvement)