Fix UnboundLocalError in create_finetuning_job when validation_data is None#45956
Open
saanikaguptamicrosoft wants to merge 3 commits intoAzure:mainfrom
Open
Fix UnboundLocalError in create_finetuning_job when validation_data is None#45956saanikaguptamicrosoft wants to merge 3 commits intoAzure:mainfrom
saanikaguptamicrosoft wants to merge 3 commits intoAzure:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in azure-ai-ml fine-tuning job creation when validation_data is omitted (None), and adds a unit test to prevent regression.
Changes:
- Update
create_finetuning_jobto passNoneforvalidation_datawhen it isn’t provided, avoiding anUnboundLocalError. - Add a unit test validating
create_finetuning_jobworks whenvalidation_datais omitted.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/ml/azure-ai-ml/azure/ai/ml/finetuning/_create_job.py | Prevents UnboundLocalError by conditionally passing None for validation_data. |
| sdk/ml/azure-ai-ml/tests/finetuning_job/unittests/test_finetuning_job_convesion.py | Adds regression coverage for validation_data=None behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
Testing
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines