[Python] TypeSpec migration for azure-mgmt-policyinsights

sdk/policyinsights/azure-mgmt-policyinsights/MANIFEST.in

@@ -1,7 +1,7 @@
-recursive-include tests *.py *.json
-recursive-include samples *.py *.md
 include *.md
-include azure/__init__.py
-include azure/mgmt/__init__.py
 include LICENSE
 include azure/mgmt/policyinsights/py.typed
+recursive-include tests *.py
+recursive-include samples *.py *.md
+include azure/__init__.py
+include azure/mgmt/__init__.py

sdk/policyinsights/azure-mgmt-policyinsights/_metadata.json

@@ -1,11 +1,10 @@
 {
-  "commit": "6c548b0bd279f5e233661b1c81fb5b61b19965cd",
+  "apiVersions": {
+    "PolicyInsightsApi": "2024-10-01",
+    "PolicyTrackedResourcesApi": "2018-07-01-preview"
+  },
+  "commit": "2591fd845ec7b248d1e9e1500b35d1db8d48dd45",
   "repository_url": "https://github.com/Azure/azure-rest-api-specs",
-  "autorest": "3.10.2",
-  "use": [
-    "@autorest/python@6.35.0",
-    "@autorest/modelerfour@4.27.0"
-  ],
-  "autorest_command": "autorest specification/policyinsights/resource-manager/readme.md --generate-sample=True --generate-test=True --include-x-ms-examples-original-file=True --python --python-sdks-folder=/mnt/vss/_work/1/azure-sdk-for-python/sdk --use=@autorest/python@6.35.0 --use=@autorest/modelerfour@4.27.0 --version=3.10.2 --version-tolerant=False",
-  "readme": "specification/policyinsights/resource-manager/readme.md"
+  "typespec_src": "specification/policyinsights/resource-manager/Microsoft.PolicyInsights/PolicyInsights",
+  "emitterVersion": "0.61.1"
 }

sdk/policyinsights/azure-mgmt-policyinsights/azure/__init__.py

@@ -1 +1 @@
-__path__ = __import__("pkgutil").extend_path(__path__, __name__)
+__path__ = __import__("pkgutil").extend_path(__path__, __name__)  # type: ignore

sdk/policyinsights/azure-mgmt-policyinsights/azure/mgmt/__init__.py

@@ -1 +1 @@
-__path__ = __import__("pkgutil").extend_path(__path__, __name__)
+__path__ = __import__("pkgutil").extend_path(__path__, __name__)  # type: ignore

sdk/policyinsights/azure-mgmt-policyinsights/azure/mgmt/policyinsights/__init__.py

@@ -2,7 +2,7 @@
 # --------------------------------------------------------------------------
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License. See License.txt in the project root for license information.
-# Code generated by Microsoft (R) AutoRest Code Generator.
+# Code generated by Microsoft (R) Python Code Generator.
 # Changes may cause incorrect behavior and will be lost if the code is regenerated.
 # --------------------------------------------------------------------------
 # pylint: disable=wrong-import-position
@@ -12,7 +12,7 @@
 if TYPE_CHECKING:
     from ._patch import *  # pylint: disable=unused-wildcard-import
 
-from ._policy_insights_client import PolicyInsightsClient  # type: ignore
+from ._client import PolicyInsightsManagementClient  # type: ignore
 from ._version import VERSION
 
 __version__ = VERSION
@@ -25,7 +25,7 @@
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [
-    "PolicyInsightsClient",
+    "PolicyInsightsManagementClient",
 ]
 __all__.extend([p for p in _patch_all if p not in __all__])  # pyright: ignore
 

sdk/policyinsights/azure-mgmt-policyinsights/azure/mgmt/policyinsights/_policy_insights_client.py → sdk/policyinsights/azure-mgmt-policyinsights/azure/mgmt/policyinsights/_client.py

@@ -2,7 +2,7 @@
 # --------------------------------------------------------------------------
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License. See License.txt in the project root for license information.
-# Code generated by Microsoft (R) AutoRest Code Generator.
+# Code generated by Microsoft (R) Python Code Generator.
 # Changes may cause incorrect behavior and will be lost if the code is regenerated.
 # --------------------------------------------------------------------------
 
@@ -17,8 +17,7 @@
 from azure.mgmt.core.policies import ARMAutoResourceProviderRegistrationPolicy
 from azure.mgmt.core.tools import get_arm_endpoints
 
-from . import models as _models
-from ._configuration import PolicyInsightsClientConfiguration
+from ._configuration import PolicyInsightsManagementClientConfiguration
 from ._utils.serialization import Deserializer, Serializer
 from .operations import (
     AttestationsOperations,
@@ -33,52 +32,68 @@
 )
 
 if TYPE_CHECKING:
+    from azure.core import AzureClouds
     from azure.core.credentials import TokenCredential
 
 
-class PolicyInsightsClient:  # pylint: disable=client-accepts-api-version-keyword,too-many-instance-attributes
-    """Query component policy states at varying resource scopes for Resource Provider mode policies.
+class PolicyInsightsManagementClient:  # pylint: disable=client-accepts-api-version-keyword,too-many-instance-attributes
+    """PolicyInsightsManagementClient.
 
-    :ivar policy_tracked_resources: PolicyTrackedResourcesOperations operations
-    :vartype policy_tracked_resources:
-     azure.mgmt.policyinsights.operations.PolicyTrackedResourcesOperations
+    :ivar operations: Operations operations
+    :vartype operations: azure.mgmt.policyinsights.operations.Operations
     :ivar remediations: RemediationsOperations operations
     :vartype remediations: azure.mgmt.policyinsights.operations.RemediationsOperations
+    :ivar attestations: AttestationsOperations operations
+    :vartype attestations: azure.mgmt.policyinsights.operations.AttestationsOperations
+    :ivar policy_metadata: PolicyMetadataOperations operations
+    :vartype policy_metadata: azure.mgmt.policyinsights.operations.PolicyMetadataOperations
     :ivar policy_events: PolicyEventsOperations operations
     :vartype policy_events: azure.mgmt.policyinsights.operations.PolicyEventsOperations
     :ivar policy_states: PolicyStatesOperations operations
     :vartype policy_states: azure.mgmt.policyinsights.operations.PolicyStatesOperations
-    :ivar policy_metadata: PolicyMetadataOperations operations
-    :vartype policy_metadata: azure.mgmt.policyinsights.operations.PolicyMetadataOperations
     :ivar policy_restrictions: PolicyRestrictionsOperations operations
     :vartype policy_restrictions: azure.mgmt.policyinsights.operations.PolicyRestrictionsOperations
     :ivar component_policy_states: ComponentPolicyStatesOperations operations
     :vartype component_policy_states:
      azure.mgmt.policyinsights.operations.ComponentPolicyStatesOperations
-    :ivar operations: Operations operations
-    :vartype operations: azure.mgmt.policyinsights.operations.Operations
-    :ivar attestations: AttestationsOperations operations
-    :vartype attestations: azure.mgmt.policyinsights.operations.AttestationsOperations
-    :param credential: Credential needed for the client to connect to Azure. Required.
+    :ivar policy_tracked_resources: PolicyTrackedResourcesOperations operations
+    :vartype policy_tracked_resources:
+     azure.mgmt.policyinsights.operations.PolicyTrackedResourcesOperations
+    :param credential: Credential used to authenticate requests to the service. Required.
     :type credential: ~azure.core.credentials.TokenCredential
-    :param subscription_id: Microsoft Azure subscription ID. Required.
+    :param subscription_id: The ID of the target subscription. The value must be an UUID. Required.
     :type subscription_id: str
-    :param base_url: Service URL. Default value is None.
+    :param base_url: Service host. Default value is None.
     :type base_url: str
+    :keyword cloud_setting: The cloud setting for which to get the ARM endpoint. Default value is
+     None.
+    :paramtype cloud_setting: ~azure.core.AzureClouds
     :keyword int polling_interval: Default waiting time between two polls for LRO operations if no
      Retry-After header is present.
     """
 
     def __init__(
-        self, credential: "TokenCredential", subscription_id: str, base_url: Optional[str] = None, **kwargs: Any
+        self,
+        credential: "TokenCredential",
+        subscription_id: str,
+        base_url: Optional[str] = None,
+        *,
+        cloud_setting: Optional["AzureClouds"] = None,
+        **kwargs: Any
     ) -> None:
-        _cloud = kwargs.pop("cloud_setting", None) or settings.current.azure_cloud  # type: ignore
+        _endpoint = "{endpoint}"
+        _cloud = cloud_setting or settings.current.azure_cloud  # type: ignore
         _endpoints = get_arm_endpoints(_cloud)
         if not base_url:
             base_url = _endpoints["resource_manager"]
         credential_scopes = kwargs.pop("credential_scopes", _endpoints["credential_scopes"])
-        self._config = PolicyInsightsClientConfiguration(
-            credential=credential, subscription_id=subscription_id, credential_scopes=credential_scopes, **kwargs
+        self._config = PolicyInsightsManagementClientConfiguration(
+            credential=credential,
+            subscription_id=subscription_id,
+            base_url=cast(str, base_url),
+            cloud_setting=cloud_setting,
+            credential_scopes=credential_scopes,
+            **kwargs
         )
 
         _policies = kwargs.pop("policies", None)
@@ -99,35 +114,34 @@ def __init__(
                 policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
                 self._config.http_logging_policy,
             ]
-        self._client: ARMPipelineClient = ARMPipelineClient(base_url=cast(str, base_url), policies=_policies, **kwargs)
+        self._client: ARMPipelineClient = ARMPipelineClient(base_url=cast(str, _endpoint), policies=_policies, **kwargs)
 
-        client_models = {k: v for k, v in _models.__dict__.items() if isinstance(v, type)}
-        self._serialize = Serializer(client_models)
-        self._deserialize = Deserializer(client_models)
+        self._serialize = Serializer()
+        self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
-        self.policy_tracked_resources = PolicyTrackedResourcesOperations(
-            self._client, self._config, self._serialize, self._deserialize
-        )
+        self.operations = Operations(self._client, self._config, self._serialize, self._deserialize)
         self.remediations = RemediationsOperations(self._client, self._config, self._serialize, self._deserialize)
+        self.attestations = AttestationsOperations(self._client, self._config, self._serialize, self._deserialize)
+        self.policy_metadata = PolicyMetadataOperations(self._client, self._config, self._serialize, self._deserialize)
         self.policy_events = PolicyEventsOperations(self._client, self._config, self._serialize, self._deserialize)
         self.policy_states = PolicyStatesOperations(self._client, self._config, self._serialize, self._deserialize)
-        self.policy_metadata = PolicyMetadataOperations(self._client, self._config, self._serialize, self._deserialize)
         self.policy_restrictions = PolicyRestrictionsOperations(
             self._client, self._config, self._serialize, self._deserialize
         )
         self.component_policy_states = ComponentPolicyStatesOperations(
             self._client, self._config, self._serialize, self._deserialize
         )
-        self.operations = Operations(self._client, self._config, self._serialize, self._deserialize)
-        self.attestations = AttestationsOperations(self._client, self._config, self._serialize, self._deserialize)
+        self.policy_tracked_resources = PolicyTrackedResourcesOperations(
+            self._client, self._config, self._serialize, self._deserialize
+        )
 
-    def _send_request(self, request: HttpRequest, *, stream: bool = False, **kwargs: Any) -> HttpResponse:
+    def send_request(self, request: HttpRequest, *, stream: bool = False, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest
         >>> request = HttpRequest("GET", "https://www.example.org/")
         <HttpRequest [GET], url: 'https://www.example.org/'>
-        >>> response = client._send_request(request)
+        >>> response = client.send_request(request)
         <HttpResponse: 200 OK>
 
         For more information on this code flow, see https://aka.ms/azsdk/dpcodegen/python/send_request
@@ -140,7 +154,11 @@ def _send_request(self, request: HttpRequest, *, stream: bool = False, **kwargs:
         """
 
         request_copy = deepcopy(request)
-        request_copy.url = self._client.format_url(request_copy.url)
+        path_format_arguments = {
+            "endpoint": self._serialize.url("self._config.base_url", self._config.base_url, "str", skip_quote=True),
+        }
+
+        request_copy.url = self._client.format_url(request_copy.url, **path_format_arguments)
         return self._client.send_request(request_copy, stream=stream, **kwargs)  # type: ignore
 
     def close(self) -> None:

sdk/policyinsights/azure-mgmt-policyinsights/azure/mgmt/policyinsights/_configuration.py

@@ -2,41 +2,56 @@
 # --------------------------------------------------------------------------
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License. See License.txt in the project root for license information.
-# Code generated by Microsoft (R) AutoRest Code Generator.
+# Code generated by Microsoft (R) Python Code Generator.
 # Changes may cause incorrect behavior and will be lost if the code is regenerated.
 # --------------------------------------------------------------------------
 
-from typing import Any, TYPE_CHECKING
+from typing import Any, Optional, TYPE_CHECKING
 
 from azure.core.pipeline import policies
 from azure.mgmt.core.policies import ARMChallengeAuthenticationPolicy, ARMHttpLoggingPolicy
 
 from ._version import VERSION
 
 if TYPE_CHECKING:
+    from azure.core import AzureClouds
     from azure.core.credentials import TokenCredential
 
 
-class PolicyInsightsClientConfiguration:  # pylint: disable=too-many-instance-attributes
-    """Configuration for PolicyInsightsClient.
+class PolicyInsightsManagementClientConfiguration:  # pylint: disable=too-many-instance-attributes,name-too-long
+    """Configuration for PolicyInsightsManagementClient.
 
     Note that all parameters used to create this instance are saved as instance
     attributes.
 
-    :param credential: Credential needed for the client to connect to Azure. Required.
+    :param credential: Credential used to authenticate requests to the service. Required.
     :type credential: ~azure.core.credentials.TokenCredential
-    :param subscription_id: Microsoft Azure subscription ID. Required.
+    :param subscription_id: The ID of the target subscription. The value must be an UUID. Required.
     :type subscription_id: str
+    :param base_url: Service host. Default value is "https://management.azure.com".
+    :type base_url: str
+    :param cloud_setting: The cloud setting for which to get the ARM endpoint. Default value is
+     None.
+    :type cloud_setting: ~azure.core.AzureClouds
     """
 
-    def __init__(self, credential: "TokenCredential", subscription_id: str, **kwargs: Any) -> None:
+    def __init__(
+        self,
+        credential: "TokenCredential",
+        subscription_id: str,
+        base_url: str = "https://management.azure.com",
+        cloud_setting: Optional["AzureClouds"] = None,
+        **kwargs: Any
+    ) -> None:
         if credential is None:
             raise ValueError("Parameter 'credential' must not be None.")
         if subscription_id is None:
             raise ValueError("Parameter 'subscription_id' must not be None.")
 
         self.credential = credential
         self.subscription_id = subscription_id
+        self.base_url = base_url
+        self.cloud_setting = cloud_setting
         self.credential_scopes = kwargs.pop("credential_scopes", ["https://management.azure.com/.default"])
         kwargs.setdefault("sdk_moniker", "mgmt-policyinsights/{}".format(VERSION))
         self.polling_interval = kwargs.get("polling_interval", 30)

sdk/policyinsights/azure-mgmt-policyinsights/azure/mgmt/policyinsights/_patch.py

@@ -1,14 +1,15 @@
-# ------------------------------------
-# Copyright (c) Microsoft Corporation.
-# Licensed under the MIT License.
-# ------------------------------------
+# coding=utf-8
+# --------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for license information.
+# --------------------------------------------------------------------------
 """Customize generated code here.
 
 Follow our quickstart for examples: https://aka.ms/azsdk/python/dpcodegen/python/customize
 """
-from typing import List
 
-__all__: List[str] = []  # Add all objects you want publicly available to users at this package level
+
+__all__: list[str] = []  # Add all objects you want publicly available to users at this package level
 
 
 def patch_sdk():

sdk/policyinsights/azure-mgmt-policyinsights/azure/mgmt/policyinsights/_utils/__init__.py

@@ -1,6 +1,6 @@
 # --------------------------------------------------------------------------
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License. See License.txt in the project root for license information.
-# Code generated by Microsoft (R) AutoRest Code Generator.
+# Code generated by Microsoft (R) Python Code Generator.
 # Changes may cause incorrect behavior and will be lost if the code is regenerated.
 # --------------------------------------------------------------------------