[CODEOWNERS Data Quality] Fix up CODEOWNERS #44945
Conversation
danieljurek
requested review from
a team,
kashifkhan and
xiangyan99
as code owners
| /sdk/core/azure-core-tracing-opentelemetry/ @pvaneck | ||
|
|
||
| # Smoke Tests | ||
| /common/smoketest/ @lmazuel @chlowell @annatisch @mccoyp @shurd @southpolesteve |
There was a problem hiding this comment.
Smoke tests aren't client libraries.
| /sdk/monitor/azure-monitor-querymetrics/ @Azure/azure-sdk-write-monitor-query-metrics | ||
|
|
||
| # PRLabel: %Monitor | ||
| /sdk/monitor/* @pvaneck |
There was a problem hiding this comment.
I'm going to be removing wildcards as much as possible so we get a very clear snapshot of owners at the level of services (/sdk/service/) and packages (/sdk/service/package-1).
| # ServiceLabel: %Data Factory | ||
| # PRLabel: %Data Factory | ||
| /sdk/datafactory/ @hvermis | ||
|
|
There was a problem hiding this comment.
Putting comments on top of multiple paths doesn't get handled the same way in the CODEOWNERS parser for @ mentions, etc.
For example:
# ServiceLabel: %Awesome Service
/sdk/awesome/
/sdk/awesome-ml/
Gets interpreted as:
# ServiceLabel: %Awesome Service
/sdk/awesome/
/sdk/awesome-ml/
This makes up the bulk of changes in this repo.
There was a problem hiding this comment.
Pull request overview
This PR aims to fix data quality issues in the CODEOWNERS file to better align with a proposed data model for easier automation and rendering. The changes primarily focus on reorganizing entries, removing wildcards, adding consistent blank line separators, and adding label comments for better structure.
Changes:
- Relocated the smoke tests entry from the end of the file to the core section (lines 28-30)
- Replaced the wildcard
/sdk/monitor/*entry with a specific/sdk/monitor/directory entry - Added blank lines and label comments for improved consistency and separation between different SDK services (ML-Jobs, ML-AutoML, ML-ImportJob, Mixed Reality sections)
| # ServiceLabel: %Data Factory | ||
| # PRLabel: %Data Factory | ||
| /sdk/datalake/ @ro-joowan |
There was a problem hiding this comment.
The ServiceLabel and PRLabel for "/sdk/datalake/" are incorrectly set to "Data Factory". The datalake directory contains Azure Data Lake Analytics and Store management packages, not Data Factory packages. These labels should be changed to an appropriate Data Lake label instead of "Data Factory".
There was a problem hiding this comment.
@danieljurek , Copilot is right. I don't know where is the list of label, but let's put the right thing please
| /eng/emitter-package-lock.json @mccoyp @catalinaperalta @iscai-msft | ||
|
|
||
| /pylintrc @l0lawrence @scbedd @mccoyp | ||
| /sdk/**/ci.yml @msyyc @lmazuel @scbedd |
There was a problem hiding this comment.
FYI: This routes all scheduled CI build failures (things like Build Docs, etc.) to these contacts instead of the service owners. Only Python has CODEOWNERS defined for all ci.yml files.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| # ServiceLabel: %Data Factory | ||
| # PRLabel: %Data Factory | ||
| /sdk/datalake/ @ro-joowan |
There was a problem hiding this comment.
@danieljurek , Copilot is right. I don't know where is the list of label, but let's put the right thing please
Fix possible errors in CODEOWNERS data quality that do not obviously fit into the proposed data model. This will make automating importing/rendering of the data model easier.