Skip to content

Update MCP sample, as api version must be higher than or equal to 2026-01-01-preview #44898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
niuzheng168 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update MCP sample, as api version must be higher than or equal to 2026-01-01-preview #44898

niuzheng168 wants to merge 1 commit into from

Conversation

@niuzheng168
Copy link

@niuzheng168 niuzheng168 commented Jan 28, 2026

Description

Update MCP sample, as api version must be higher than or equal to 2026-01-01-preview

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings January 28, 2026 13:17
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Voice Live labels Jan 28, 2026
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Thank you for your contribution @niuzheng168! We will review the pull request and get back to you soon.

Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the MCP (Model Context Protocol) sample to use the required API version parameter instead of a query parameter feature flag. The change reflects a requirement that MCP features must use an API version of 2026-01-01-preview or higher.

Changes:

  • Added api_version="2026-01-01-preview" parameter to the connect() function call in the MCP sample
  • Removed the features=mcp_preview:true query parameter from the default endpoint configuration
  • Updated comments to document the API version requirement

sdk/ai/azure-ai-voicelive/samples/async_mcp_sample.py
endpoint=self.endpoint,
credential=self.credential,
model=self.model,
api_version="2026-01-01-preview", # To use MCP features, the api version must be higher than or equal to 2026-01-01-preview
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comment is too long and doesn't follow PEP 8 guidelines which recommend keeping lines under 79 characters (or at most 99 characters for code with comments). Consider moving this comment to a separate line above the parameter for better readability.

Suggested change
api_version="2026-01-01-preview", # To use MCP features, the api version must be higher than or equal to 2026-01-01-preview
# To use MCP features, the api_version must be >= 2026-01-01-preview
api_version="2026-01-01-preview",

Copilot uses AI. Check for mistakes.
sdk/ai/azure-ai-voicelive/samples/async_mcp_sample.py
endpoint=self.endpoint,
credential=self.credential,
model=self.model,
api_version="2026-01-01-preview", # To use MCP features, the api version must be higher than or equal to 2026-01-01-preview
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions that the CHANGELOG is updated for this change, but no changes to CHANGELOG.md are included in this pull request. Since this is a sample update that changes how MCP features should be used (requiring a specific API version instead of a query parameter), it should be documented in the CHANGELOG under the "Unreleased" section.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@xitzhang xitzhang xitzhang approved these changes

@rhurey rhurey Awaiting requested review from rhurey rhurey is a code owner

@amber-yujueWang amber-yujueWang Awaiting requested review from amber-yujueWang amber-yujueWang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Voice Live

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@niuzheng168 @xitzhang