Container Registry TSP #44848
Open
Container Registry TSP #44848
+8,419
−4,015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
kashifkhan
force-pushed
the
cr_regen_tsp
branch
from
31f0b32 to
9d682cc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR represents a major regeneration of the Azure Container Registry SDK from AutoRest to TypeSpec-based code generation. The changes include:
Changes:
- Migration from setup.py to pyproject.toml for package configuration
- Regeneration of all generated code using TypeSpec
- Parameter name changes in generated clients (url → endpoint)
- Updated serialization/deserialization infrastructure
- Breaking change: Python minimum version increased from 3.8 to 3.9
Reviewed changes
Copilot reviewed 51 out of 53 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | New TypeSpec configuration file (contains placeholder values) |
| pyproject.toml | Replaces setup.py with modern packaging configuration |
| setup.py | Deleted - migrated to pyproject.toml |
| _generated/* | Complete regeneration of generated code with new generator |
| _models.py | Updated type annotations to Optional for various properties |
| *_client.py | Updated to use new generated client with endpoint parameter |
| tests/* | Updated mocks to match new generated code structure |
| samples/* | Updated snippet markers and added type: ignore comments |
sdk/containerregistry/azure-containerregistry/tsp-location.yaml
Outdated
Show resolved
Hide resolved
sdk/containerregistry/azure-containerregistry/azure/containerregistry/_generated/_version.py
Show resolved
Hide resolved
sdk/containerregistry/azure-containerregistry/azure/containerregistry/_models.py
Outdated
Show resolved
Hide resolved
sdk/containerregistry/azure-containerregistry/tests/test_container_registry_client_async.py
Show resolved
Hide resolved
sdk/containerregistry/azure-containerregistry/tests/test_container_registry_client.py
Show resolved
Hide resolved
kashifkhan
force-pushed
the
cr_regen_tsp
branch
from
d078af1 to
93fb7f1
Compare
Member
Author
|
/azp run python-containerregistry-ci |
|
No pipelines are associated with this pull request. |
kashifkhan
force-pushed
the
cr_regen_tsp
branch
from
93fb7f1 to
b6cd481
Compare
kashifkhan
force-pushed
the
cr_regen_tsp
branch
from
defa72a to
c246edf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines