Docs: change default package source override to Dev feed#49490
Open
danieljurek wants to merge 1 commit into
Open
Docs: change default package source override to Dev feed#49490danieljurek wants to merge 1 commit into
danieljurek wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Java docs onboarding generation to default to the Azure SDK public DevOps Maven feed, removing the explicit daily-docs override so the pipeline relies on the script’s default package source.
Changes:
- Change the default
packageDownloadUrlinDocs-Onboarding.ps1from Maven Central to the Java public dev feed. - Remove the
-PackageSourceOverrideargument from the daily docs onboarding step ineng/pipelines/docindex.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/scripts/docs/Docs-Onboarding.ps1 | Switches the default onboarding package source to the public dev feed. |
| eng/pipelines/docindex.yml | Stops passing an explicit daily-docs package source override (now relies on script default). |
Comments suppressed due to low confidence (1)
eng/scripts/docs/Docs-Onboarding.ps1:35
- With the default package source now pointing to the DevOps feed, packages that only exist on Maven Central will need a per-package override. However, this function currently ignores a top-level
packageDownloadUrlvalue in the metadata (it always uses the global default unlessDocsCiConfigPropertiesoverwrites it). If the docs metadata JSONs are updated as described in the PR to include"packageDownloadUrl": "https://repo1.maven.org/maven2", that override will be silently ignored and those packages will still be onboarded against the dev feed.
$packageDownloadUrl = 'https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-java/maven/v1'
if ($PackageSourceOverride) {
$packageDownloadUrl = $PackageSourceOverride
}
$onboardedPackages = @()
foreach ($package in $metadata) {
$packageInfo = [ordered]@{
packageArtifactId = $package.Name
packageGroupId = $package.Group
packageVersion = $package.Version
packageDownloadUrl = $packageDownloadUrl
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates the onboarding file with the dev feed as the default URL.
DEPENDS ON migration of legacy packages to use
in their metadata JSONs if the package does not exist in the Dev Feed (i.e. mostly legacy or packages that ship outside of the Azure SDK EngSys)