Skip to content

Adjust logging to avoid expensive CosmosException.getMessage() diagnostics json serialization #49321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jaxpod70 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Adjust logging to avoid expensive CosmosException.getMessage() diagnostics json serialization #49321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...in/java/com/azure/cosmos/implementation/changefeed/epkversion/PartitionProcessorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,17 @@ public Mono<Void> run(CancellationToken cancellationToken) {

CosmosException clientException = (CosmosException) throwable;
logger.warn(
"Lease with token " + this.lease.getLeaseToken() + ": CosmosException was thrown from thread " +
Thread.currentThread().getId() + " for lease with owner " + this.lease.getOwner(),
clientException);
"Lease with token {}: CosmosException was thrown from thread {} for lease with owner {} {}",
this.lease.getLeaseToken(),
Thread.currentThread().getId(),
this.lease.getOwner(),
clientException.getShortMessage());
if (logger.isDebugEnabled()) {
logger.debug(
"Lease with token " + this.lease.getLeaseToken() + ": CosmosException was thrown from thread " +
Thread.currentThread().getId() + " for lease with owner " + this.lease.getOwner(),
clientException);
}
StatusCodeErrorType docDbError =
ExceptionClassifier.classifyClientException(clientException);

Expand Down
15 changes: 12 additions & 3 deletions ...ain/java/com/azure/cosmos/implementation/changefeed/pkversion/PartitionProcessorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,18 @@ public Mono<Void> run(CancellationToken cancellationToken) {
// we know it is a terminal event.

CosmosException clientException = (CosmosException) throwable;
logger.warn("CosmosException: Partition " + this.lease.getLeaseToken()
+ " from thread " + Thread.currentThread().getId() + " with owner " + this.lease.getOwner(),
clientException);
logger.warn(
"CosmosException: partition {} from thread {} with owner {} {}",
this.lease.getLeaseToken(),
Thread.currentThread().getId(),
this.lease.getOwner(),
clientException.getShortMessage());
if (logger.isDebugEnabled()) {
logger.debug(
"CosmosException: partition" + this.lease.getLeaseToken()
+ "from thread " + Thread.currentThread().getId() + " with owner " + this.lease.getOwner(),
clientException);
}
StatusCodeErrorType docDbError = ExceptionClassifier.classifyClientException(clientException);

switch (docDbError) {
Expand Down
Loading