Add timeouts for JWT decoder in AadResourceServerConfiguration#49312
Open
berry120 wants to merge 2 commits into
Open
Add timeouts for JWT decoder in AadResourceServerConfiguration#49312berry120 wants to merge 2 commits into
berry120 wants to merge 2 commits into
Conversation
Set connection and read timeouts for JWT decoder.
Contributor
|
Thank you for your contribution @berry120! We will review the pull request and get back to you soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set default read & connect timeouts on NimbusJwtDecoder.
Description
This spring security issue highlighted the potential for 15 minute (or longer) hangs due to the absence of explicit connect & read timeouts on the NimbusJwtDecoder. This is fixed in Spring Security, however the Azure SDK explicitly overrides
restOperationsin the NimbusJwtDecoder it creates, meaning we need the fix explicitly here, too.As a current workaround, the following can be defined as a bean on a configuration class:
However, this isn't ideal as it applies globally, and has to be specified in each project.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines