-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Cosmos Spark] Surface empty change feed pages to avoid end-to-end timeout #49276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tvaron3
wants to merge
17
commits into
Azure:main
Choose a base branch
from
tvaron3:tvaron3/spark-allow-empty-pages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2e43e14
[Cosmos Spark] Surface empty change feed pages to avoid end-to-end ti…
tvaron3 8616057
Add PR link to CHANGELOG entries
tvaron3 08f690b
Restore noChanges short-circuit in isFullyDrained when emptyPagesAllo…
tvaron3 48a9e99
Address pass-3 review: defense-in-depth on NO_RETRY + DRY cleanup
tvaron3 0304dfe
Address pass-4 review: lock contract on data-page non-termination
tvaron3 34d3da4
Shrink bridge accessor surface; reclassify CHANGELOG entry
tvaron3 255bad9
Address pass-5 review (Kushagra + Annie): drift hazard, test coverage…
tvaron3 5683b08
De-flake CosmosContainerChangeFeedTest.asyncChangeFeedPrefetching
tvaron3 635d86d
change
xinlian12 0fd65d3
add one more change
xinlian12 277db10
Fix asyncChangeFeedPrefetching FULL_FIDELITY: insert AFTER subscribe
tvaron3 2e62c35
Merge pull request #1 from xinlian12/tvaron3/spark-allow-empty-pages
tvaron3 7fa6a1a
Address @xinlian12 review: rename changefeed flag, fix broken test, a…
tvaron3 c7478c9
Stabilize asyncChangeFeedPrefetching on Windows EmulatorTcp
tvaron3 578ddc8
Revert asyncChangeFeedPrefetching to original Thread.sleep shape + ad…
tvaron3 098f378
Remove stale TODO-style comment on surfaceOrRetryNoChangesPage
tvaron3 87a90bb
Merge branch 'main' into tvaron3/spark-allow-empty-pages
tvaron3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.