fixFewTests - Part3 by xinlian12 · Pull Request #47939 · Azure/azure-sdk-for-java

xinlian12 · 2026-02-08T05:11:35Z

No description provided.

- Add isSuccessStatusCode() validation for non-2xx bulk responses in all 3 sites (impl/TestSuiteBase truncateCollection, rx/TestSuiteBase cleanUpContainerInternal, rx/TestSuiteBase bulkInsert) - Keep 409/Conflict handling in bulkInsert but validate other non-2xx responses - Return server-created items from bulkInsertBlocking via getItem(clazz) - Use PartitionKey.NONE instead of new PartitionKey(null) in cleanUpContainerInternal

…agation Use BridgeInternal.createCosmosException() with status code and substatus code from CosmosBulkItemResponse instead of generic IllegalStateException.

- Add insertUsingPointOperations for one-by-one createItem path - Add bulkEnabled parameter to insertAllItemsBlocking/voidInsertAllItemsBlocking - Rename bulkInsertBlocking -> insertAllItemsBlocking - Rename voidBulkInsertBlocking -> voidInsertAllItemsBlocking - Update all callers with explicit bulkEnabled=true

xinlian12 · 2026-02-08T05:11:44Z

/azp run java - cosmos - tests

azure-pipelines · 2026-02-08T05:12:08Z

Azure Pipelines successfully started running 1 pipeline(s).

xinlian12 · 2026-02-08T05:27:12Z

/azp run java - cosmos - tests

azure-pipelines · 2026-02-08T05:27:32Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR focuses on stabilizing Cosmos SDK test execution by standardizing test container cleanup and item insertion patterns, and by adding extra diagnostics in a few flaky scenarios.

Changes:

Replaced many test usages of truncateCollection(...) / bulkInsertBlocking(...) with cleanUpContainer(...) and insertAllItemsBlocking(..., bulkEnabled) in Rx test suites.
Refactored Rx test base cleanup/insertion helpers to use partition-key aware bulk operations in more places.
Added additional test diagnostics/logging (and one timing workaround) to help investigate intermittent failures.

Reviewed changes

Copilot reviewed 36 out of 37 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java	Minor whitespace-only diff in client initialization block.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/changefeed/pkversion/IncrementalChangeFeedProcessorTest.java	Updated change feed tests to use new bulk insert helper signature.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/changefeed/epkversion/IncrementalChangeFeedProcessorTest.java	Updated change feed tests to use new bulk insert helper signature.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/changefeed/epkversion/FullFidelityChangeFeedProcessorTest.java	Updated change feed tests to use new bulk insert helper signature.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/changefeed/epkversion/ChangeFeedProcessorMigrationTests.java	Switched setup insert helper for migration tests.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/VeryLargeDocumentQueryTest.java	Switched setup cleanup helper to `cleanUpContainer`.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/UserDefinedFunctionUpsertReplaceTest.java	Switched setup cleanup helper to `cleanUpContainer`.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/UserDefinedFunctionQueryTest.java	Switched setup cleanup helper to `cleanUpContainer`.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/TriggerUpsertReplaceTest.java	Switched setup cleanup helper to `cleanUpContainer`.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/TriggerQueryTest.java	Switched setup cleanup helper to `cleanUpContainer`.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/TopQueryTests.java	Switched setup cleanup helper to `cleanUpContainer`.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/TestSuiteBase.java	Reworked cleanup and insert helpers; introduced bulk-operation-based insert/delete utilities.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/StoredProcedureQueryTest.java	Switched setup cleanup helper to `cleanUpContainer`.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/SinglePartitionReadFeedDocumentsTest.java	Switched setup cleanup helper and item insertion helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/SinglePartitionDocumentQueryTest.java	Switched setup cleanup helper to `cleanUpContainer`.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/ReadFeedUdfsTest.java	Switched setup cleanup helper to `cleanUpContainer`.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/ReadFeedTriggersTest.java	Switched setup cleanup helper to `cleanUpContainer`.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/ReadFeedStoredProceduresTest.java	Switched setup cleanup helper to `cleanUpContainer`.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/ReadFeedDocumentsTest.java	Switched setup cleanup helper and item insertion helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/QueryValidationTests.java	Switched setup cleanup helper and item insertion helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/ParallelDocumentQueryTest.java	Switched setup cleanup helper and item insertion helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/OrderbyDocumentQueryTest.java	Renamed helper and switched cleanup/insertion to new helpers.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/OffsetLimitQueryTests.java	Switched setup cleanup helper and bulk insert helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/MultiOrderByQueryTests.java	Switched setup cleanup helper and bulk insert helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/GroupByQueryTests.java	Switched setup cleanup helper and bulk insert helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/FeedRangeQueryTests.java	Switched setup cleanup helper and item insertion helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/DistinctQueryTests.java	Switched setup cleanup helper and bulk insert helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/ContainerCreateDeleteWithSameNameTest.java	Switched setup insert helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/ClientRetryPolicyE2ETests.java	Added additional diagnostics logging for slow test runs.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/BackPressureTest.java	Switched setup insert helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/BackPressureCrossPartitionTest.java	Switched setup insert helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/AggregateQueryTests.java	Switched setup cleanup helper and bulk insert helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/implementation/TestSuiteBase.java	Refactored `truncateCollection` to use async SDK container + bulk deletes and script cleanup.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/faultinjection/FaultInjectionServerErrorRuleOnDirectTests.java	Added a fixed delay before validating diagnostics for async address refresh.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/EndToEndTimeOutValidationTests.java	Switched setup cleanup helper and item insertion helper.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosNotFoundTests.java	Added extra diagnostics logging when unexpected substatus is observed.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosDiagnosticsTest.java	Simplified exception handling by removing redundant JsonMappingException catch.

Comments suppressed due to low confidence (2)

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/changefeed/pkversion/IncrementalChangeFeedProcessorTest.java:1011

The value passed into this flatMap is no longer a CosmosItemResponse (bulkInsert now emits CosmosBulkOperationResponse). Renaming cosmosItemResponse to something like bulkResponse/bulkOperationResponse would avoid confusion.
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/changefeed/epkversion/IncrementalChangeFeedProcessorTest.java:994
The value passed into this flatMap is no longer a CosmosItemResponse (bulkInsert now emits CosmosBulkOperationResponse). Renaming cosmosItemResponse to something like bulkResponse/bulkOperationResponse would avoid confusion.

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/implementation/TestSuiteBase.java

...rc/test/java/com/azure/cosmos/faultinjection/FaultInjectionServerErrorRuleOnDirectTests.java

...test/java/com/azure/cosmos/rx/changefeed/epkversion/FullFidelityChangeFeedProcessorTest.java

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/implementation/TestSuiteBase.java

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/TestSuiteBase.java

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/implementation/TestSuiteBase.java

xinlian12 · 2026-02-08T19:16:31Z

/azp run java - cosmos - tests

azure-pipelines · 2026-02-08T19:16:55Z

Azure Pipelines successfully started running 1 pipeline(s).

xinlian12 · 2026-02-08T21:35:13Z

/azp run java - cosmos - tests

azure-pipelines · 2026-02-08T21:35:37Z

Azure Pipelines successfully started running 1 pipeline(s).

xinlian12 · 2026-02-09T00:12:37Z

/azp run java - cosmos - tests

azure-pipelines · 2026-02-09T00:13:00Z

Azure Pipelines successfully started running 1 pipeline(s).

…mplementation/TestSuiteBase.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…aultinjection/FaultInjectionServerErrorRuleOnDirectTests.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…mplementation/TestSuiteBase.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…e-sdk-for-java into fixFewTests-part3

xinlian12 · 2026-02-09T18:39:36Z

/azp run java - cosmos - tests

azure-pipelines · 2026-02-09T18:40:02Z

Azure Pipelines successfully started running 1 pipeline(s).

xinlian12 · 2026-02-09T18:40:13Z

/azp run java - cosmos - tests

azure-pipelines · 2026-02-09T18:40:36Z

Azure Pipelines successfully started running 1 pipeline(s).

xinlian12 · 2026-02-09T18:44:08Z

/azp run java - cosmos - tests

azure-pipelines · 2026-02-09T18:44:40Z

Azure Pipelines successfully started running 1 pipeline(s).

kushagraThapar

LGTM, thanks @xinlian12

kushagraThapar · 2026-02-09T19:37:34Z

...mos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/StaleResourceRetryPolicy.java

+                logger.debug("Received name cache staled exception for collection [{}] with statusCode {}, subStatusCode {}, going to retry",
+                    collectionLink,
+                    clientException.getStatusCode(),
+                    clientException.getSubStatusCode());


wondering if status code and substatus code are enough to find out which stale exception is hit?

Annie Liang added 12 commits February 6, 2026 10:57

fix test pipeline

cc4689f

fix few tests part 2

54dbd8b

fix some tests

d2f3e17

rename

47c7aa1

simplify code

6e960fc

Replace IllegalStateException with CosmosException in bulk error prop…

fab4fd0

…agation Use BridgeInternal.createCosmosException() with status code and substatus code from CosmosBulkItemResponse instead of generic IllegalStateException.

test

6df45b3

fix test pipeline

3899f57

Merge branch 'main' into fixFewTests-part3

723fcbd

fix

42cd881

github-actions bot added the Cosmos label Feb 8, 2026

xinlian12 marked this pull request as ready for review February 8, 2026 05:27

xinlian12 requested review from a team and kirankumarkolli as code owners February 8, 2026 05:27

Copilot AI review requested due to automatic review settings February 8, 2026 05:27

xinlian12 requested a review from a team as a code owner February 8, 2026 05:27

Copilot started reviewing on behalf of xinlian12 February 8, 2026 05:28 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

Annie Liang added 4 commits February 8, 2026 11:12

fix NotFoundException tests

cc91f6e

fix test pipeline

4e8b099

merge from main and resolve conflicts

e87a2e2

Merge branch 'fixFewTests-part2' into fixFewTests-part3

7473e38

fix

804014f

fix

190ab92

Annie Liang and others added 7 commits February 9, 2026 10:27

Merge branch 'main' of https://github.com/xinlian12/azure-sdk-for-java

8109855

merge from main and resolve conflicts

9ccda0a

Update sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/i…

a75dc92

…mplementation/TestSuiteBase.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/f…

baf9fd9

…aultinjection/FaultInjectionServerErrorRuleOnDirectTests.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/i…

94823e4

…mplementation/TestSuiteBase.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix

ef1326b

Merge branch 'fixFewTests-part3' of https://github.com/xinlian12/azur…

7c1914a

…e-sdk-for-java into fixFewTests-part3

change

86f9617

xinlian12 changed the title ~~[NO Review]fixFewTests - Part3~~ fixFewTests - Part3 Feb 9, 2026

kushagraThapar approved these changes Feb 9, 2026

View reviewed changes

Conversation

xinlian12 commented Feb 8, 2026

Uh oh!

xinlian12 commented Feb 8, 2026

Uh oh!

azure-pipelines bot commented Feb 8, 2026

Uh oh!

xinlian12 commented Feb 8, 2026

Uh oh!

azure-pipelines bot commented Feb 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xinlian12 commented Feb 8, 2026

Uh oh!

azure-pipelines bot commented Feb 8, 2026

Uh oh!

xinlian12 commented Feb 8, 2026

Uh oh!

azure-pipelines bot commented Feb 8, 2026

Uh oh!

xinlian12 commented Feb 9, 2026

Uh oh!

azure-pipelines bot commented Feb 9, 2026

Uh oh!

xinlian12 commented Feb 9, 2026

Uh oh!

azure-pipelines bot commented Feb 9, 2026

Uh oh!

xinlian12 commented Feb 9, 2026

Uh oh!

azure-pipelines bot commented Feb 9, 2026

Uh oh!

xinlian12 commented Feb 9, 2026

Uh oh!

azure-pipelines bot commented Feb 9, 2026

Uh oh!

kushagraThapar left a comment

Choose a reason for hiding this comment

Uh oh!

kushagraThapar Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants