Skip to content

Conversation

@alzimmermsft
Copy link
Member

Description

Removes the snapshot test-jar for azure-mgmt-resources with copied code from the package in microsoft-azure-batch.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the test-jar dependency on azure-mgmt-resources (version 1.3.1-SNAPSHOT) by copying the necessary test infrastructure classes directly into the microsoft-azure-batch test codebase. The PR addresses a problematic snapshot dependency while maintaining the same test recording functionality.

Changes:

  • Added seven new test infrastructure classes to support HTTP request/response recording and playback during testing
  • Updated imports in BatchIntegrationTestBase.java to reference the new local classes instead of the removed test-jar dependency
  • Removed the test-jar dependency from pom.xml and external_dependencies.txt

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
sdk/batch/microsoft-azure-batch/src/test/java/com/microsoft/azure/batch/recording/TestResourceNamerFactory.java Factory class for creating TestResourceNamer instances to support deterministic resource naming during test playback
sdk/batch/microsoft-azure-batch/src/test/java/com/microsoft/azure/batch/recording/TestResourceNamer.java Custom resource namer that integrates with the InterceptorManager for record/playback functionality
sdk/batch/microsoft-azure-batch/src/test/java/com/microsoft/azure/batch/recording/TestMode.java Enum defining test execution modes (PLAYBACK and RECORD)
sdk/batch/microsoft-azure-batch/src/test/java/com/microsoft/azure/batch/recording/TestDelayProvider.java Delay provider that skips delays during playback mode to speed up test execution
sdk/batch/microsoft-azure-batch/src/test/java/com/microsoft/azure/batch/recording/RecordedData.java Data model for storing network call records and test variables
sdk/batch/microsoft-azure-batch/src/test/java/com/microsoft/azure/batch/recording/NetworkCallRecord.java Data model representing a single HTTP request/response recording
sdk/batch/microsoft-azure-batch/src/test/java/com/microsoft/azure/batch/recording/InterceptorManager.java Core infrastructure managing test recording and playback, including HTTP interception and session file management
sdk/batch/microsoft-azure-batch/src/test/java/com/microsoft/azure/batch/BatchIntegrationTestBase.java Updated imports to use the new local recording infrastructure classes
sdk/batch/microsoft-azure-batch/pom.xml Removed test-jar dependency on azure-mgmt-resources 1.3.1-SNAPSHOT
eng/versioning/external_dependencies.txt Removed the entry for the test-jar dependency

@raych1
Copy link
Member

raych1 commented Feb 5, 2026

/azp run java - batch - data - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@raych1
Copy link
Member

raych1 commented Feb 6, 2026

/azp run java - batch - data - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@raych1
Copy link
Member

raych1 commented Feb 9, 2026

/azp run java - batch - data - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft
Copy link
Member Author

/check-enforcer evaluate

@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft alzimmermsft merged commit 5d21aab into Azure:main Feb 9, 2026
35 of 36 checks passed
@alzimmermsft alzimmermsft deleted the RemoveOldDep branch February 9, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants