Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eng/lintingconfigs/checkstyle/clientcore/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -426,5 +426,8 @@
<!-- CUSTOM CHECKS -->
<!-- Ensures caught exceptions are included as exception cause in subsequently thrown exception -->
<module name="io.clientcore.linting.extensions.checkstyle.checks.UseCaughtExceptionCauseCheck"/>

<!-- Validates that classes implementing JsonSerializable or XmlSerializable have required serialization methods -->
<module name="io.clientcore.linting.extensions.checkstyle.checks.SerializableMethodsCheck"/>
</module>
</module>
3 changes: 3 additions & 0 deletions eng/lintingconfigs/checkstyle/track2/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -420,5 +420,8 @@
<module name="io.clientcore.linting.extensions.checkstyle.checks.UseCaughtExceptionCauseCheck"/>

<module name="io.clientcore.linting.extensions.checkstyle.checks.StepVerifierCheck"/>

<!-- Validates that classes implementing JsonSerializable or XmlSerializable have required serialization methods -->
<module name="io.clientcore.linting.extensions.checkstyle.checks.SerializableMethodsCheck"/>
</module>
</module>
3 changes: 3 additions & 0 deletions eng/lintingconfigs/checkstyle/vnext/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -425,5 +425,8 @@
<!-- CUSTOM CHECKS -->
<!-- Ensures caught exceptions are included as exception cause in subsequently thrown exception -->
<module name="io.clientcore.linting.extensions.checkstyle.checks.UseCaughtExceptionCauseCheck"/>

<!-- Validates that classes implementing JsonSerializable or XmlSerializable have required serialization methods -->
<module name="io.clientcore.linting.extensions.checkstyle.checks.SerializableMethodsCheck"/>
</module>
</module>
3 changes: 2 additions & 1 deletion eng/versioning/version_client.txt
Original file line number Diff line number Diff line change
Expand Up @@ -549,11 +549,12 @@ io.clientcore:optional-dependency-tests;1.0.0-beta.1;1.0.0-beta.1
# In the pom, the version update tag after the version should name the unreleased package and the dependency version:
# <!-- {x-version-update;unreleased_com.azure:azure-core;dependency} -->

unreleased_com.azure.resourcemanager:azure-resourcemanager-containerregistry;2.55.0
unreleased_com.azure.v2:azure-core;2.0.0-beta.1
unreleased_com.azure.v2:azure-identity;2.0.0-beta.1
unreleased_com.azure.v2:azure-data-appconfiguration;2.0.0-beta.1
unreleased_io.clientcore:http-netty4;1.0.0-beta.1
unreleased_com.azure.resourcemanager:azure-resourcemanager-containerregistry;2.55.0
unreleased_io.clientcore:linting-extensions;1.0.0-beta.2

# Released Beta dependencies: Copy the entry from above, prepend "beta_", remove the current
# version and set the version to the released beta. Released beta dependencies are only valid
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,24 @@
<!-- This file is generated by the /eng/scripts/linting_suppression_generator.py script. -->

<suppressions>
<suppress files="com.azure.v2.security.keyvault.administration.implementation.KeyVaultAdministrationClientImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleAssignmentsImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleDefinitionsImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.administration.KeyVaultAccessControlClient.java" checks="com.azure.tools.checkstyle.checks.ServiceClient" />
<suppress files="com.azure.v2.security.keyvault.administration.KeyVaultBackupClient.java" checks="com.azure.tools.checkstyle.checks.ServiceClient" />
<suppress files="com.azure.v2.security.keyvault.administration.KeyVaultSettingsClient.java" checks="com.azure.tools.checkstyle.checks.ServiceClient" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.KeyVaultAdministrationClientImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleAssignmentsImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleDefinitionsImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.administration.KeyVaultAccessControlClient.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ServiceClient" />
<suppress files="com.azure.v2.security.keyvault.administration.KeyVaultBackupClient.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ServiceClient" />
<suppress files="com.azure.v2.security.keyvault.administration.KeyVaultSettingsClient.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ServiceClient" />

<!-- Generated classes -->
<suppress files="com.azure.v2.security.keyvault.administration.implementation.KeyVaultAdministrationClientServiceImpl.java" checks="FinalClass" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.KeyVaultAdministrationClientServiceImpl.java" checks="com.azure.tools.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.KeyVaultAdministrationClientServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.KeyVaultAdministrationClientServiceImpl.java" checks="JavadocPackage" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.KeyVaultAdministrationClientServiceImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.KeyVaultAdministrationClientServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleAssignmentsServiceImpl.java" checks="FinalClass" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleAssignmentsServiceImpl.java" checks="com.azure.tools.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleAssignmentsServiceImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleAssignmentsServiceImpl.java" checks="JavadocPackage" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleAssignmentsServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleAssignmentsServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleDefinitionsServiceImpl.java" checks="FinalClass" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleDefinitionsServiceImpl.java" checks="com.azure.tools.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleDefinitionsServiceImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleDefinitionsServiceImpl.java" checks="JavadocPackage" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleDefinitionsServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.administration.implementation.RoleDefinitionsServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
</suppressions>
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
<suppressions>
<suppress files="com.azure.v2.security.keyvault.certificates.models.CertificateContentType.java" checks="EqualsHashCode" />
<suppress files="com.azure.v2.security.keyvault.certificates.models.CertificatePolicyAction.java" checks="EqualsHashCode" />
<suppress files="com.azure.v2.security.keyvault.certificates.implementation.CertificateClientImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.certificates.CertificateClient.java" checks="com.azure.tools.checkstyle.checks.ServiceClient" />
<suppress files="com.azure.v2.security.keyvault.certificates.implementation.CertificateClientImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.certificates.CertificateClient.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ServiceClient" />

<!-- Generated classes -->
<suppress files="com.azure.v2.security.keyvault.certificates.implementation.CertificateClientServiceImpl.java" checks="FinalClass" />
<suppress files="com.azure.v2.security.keyvault.certificates.implementation.CertificateClientServiceImpl.java" checks="com.azure.tools.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.certificates.implementation.CertificateClientServiceImpl.java" checks="JavadocPackage" />
<suppress files="com.azure.v2.security.keyvault.certificates.implementation.CertificateClientServiceImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.certificates.implementation.CertificateClientServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.certificates.implementation.*\.java" checks="JavadocPackage" />
<suppress files="com.azure.v2.security.keyvault.certificates.implementation.CertificateClientServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
</suppressions>
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@
<!-- This file is generated by the /eng/scripts/linting_suppression_generator.py script. -->

<suppressions>
<suppress files="com.azure.v2.security.keyvault.keys.implementation.KeyClientImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.SecretMinClientImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.keys.KeyClient.java" checks="com.azure.tools.checkstyle.checks.ServiceClient" />
<suppress files="com.azure.v2.security.keyvault.keys.cryptography.CryptographyClient.java" checks="com.azure.tools.checkstyle.checks.ServiceClient" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.KeyClientImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.SecretMinClientImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.keys.KeyClient.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ServiceClient" />
<suppress files="com.azure.v2.security.keyvault.keys.cryptography.CryptographyClient.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ServiceClient" />

<!-- Generated classes -->
<suppress files="com.azure.v2.security.keyvault.keys.implementation.KeyClientServiceImpl.java" checks="FinalClass" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.KeyClientServiceImpl.java" checks="com.azure.tools.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.KeyClientServiceImpl.java" checks="JavadocPackage" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.KeyClientServiceImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.KeyClientServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.*\.java" checks="JavadocPackage" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.KeyClientServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.SecretMinClientServiceImpl.java" checks="FinalClass" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.SecretMinClientServiceImpl.java" checks="com.azure.tools.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.SecretMinClientServiceImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.SecretMinClientServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.keys.implementation.SecretMinClientServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
</suppressions>
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
<!-- This file is generated by the /eng/scripts/linting_suppression_generator.py script. -->

<suppressions>
<suppress files="com.azure.v2.security.keyvault.secrets.implementation.SecretClientImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.secrets.SecretClient.java" checks="com.azure.tools.checkstyle.checks.ServiceClient" />
<suppress files="com.azure.v2.security.keyvault.secrets.implementation.SecretClientImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.secrets.SecretClient.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ServiceClient" />

<!-- Generated classes -->
<suppress files="com.azure.v2.security.keyvault.secrets.implementation.SecretClientServiceImpl.java" checks="FinalClass" />
<suppress files="com.azure.v2.security.keyvault.secrets.implementation.SecretClientServiceImpl.java" checks="com.azure.tools.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.secrets.implementation.SecretClientServiceImpl.java" checks="JavadocPackage" />
<suppress files="com.azure.v2.security.keyvault.secrets.implementation.SecretClientServiceImpl.java" checks="com.azure.tools.checkstyle.checks.RawExceptionThrow" />
<suppress files="com.azure.v2.security.keyvault.secrets.implementation.SecretClientServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.GoodLogging" />
<suppress files="com.azure.v2.security.keyvault.secrets.implementation.*\.java" checks="JavadocPackage" />
<suppress files="com.azure.v2.security.keyvault.secrets.implementation.SecretClientServiceImpl.java" checks="io.clientcore.linting.extensions.checkstyle.checks.RawExceptionThrow" />
</suppressions>
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.azure.monitor.opentelemetry.exporter.implementation.quickpulse.model;

import com.azure.json.JsonReader;
import com.azure.json.JsonSerializable;
import com.azure.json.JsonWriter;

Expand All @@ -17,4 +18,9 @@ public QuickPulseMonitoringDataPoints(List<QuickPulseEnvelope> monitoringDataPoi
public JsonWriter toJson(JsonWriter jsonWriter) throws IOException {
return jsonWriter.writeArray(monitoringDataPoints, JsonWriter::writeJson, false);
}

public static QuickPulseMonitoringDataPoints fromJson(JsonReader jsonReader) throws IOException {
List<QuickPulseEnvelope> dataPoints = jsonReader.readArray(QuickPulseEnvelope::fromJson);
return new QuickPulseMonitoringDataPoints(dataPoints);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,16 @@
@JsonClassDescription("Gets the quality of the given SDK.")
class GetSdkQualityAsync {
@JsonPropertyDescription("The name of the SDK.")
public String name;
private String name;

public String getName() {
return name;
}

public GetSdkQualityAsync setName(String name) {
this.name = name;
return this;
}

public String execute() {
return name.contains("OpenAI") ? "Excellent quality and robust implementation!" : "Unknown quality";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,16 @@
@JsonClassDescription("Gets the quality of the given SDK.")
class GetSdkQuality {
@JsonPropertyDescription("The name of the SDK.")
public String name;
private String name;

public String getName() {
return name;
}

public GetSdkQuality setName(String name) {
this.name = name;
return this;
}

public String execute() {
return name.contains("OpenAI") ? "Excellent quality and robust implementation!" : "Unknown quality";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,28 @@
@JsonClassDescription("Get the current weather in a given location")
class GetCurrentWeather {
@JsonPropertyDescription("The city and state, e.g. San Francisco, CA")
public String location;
private String location;

@JsonPropertyDescription("Temperature unit (celsius or fahrenheit)")
public String unit = "celsius";
private String unit = "celsius";

public String getLocation() {
return location;
}

public GetCurrentWeather setLocation(String location) {
this.location = location;
return this;
}

public String getUnit() {
return unit;
}

public GetCurrentWeather setUnit(String unit) {
this.unit = unit;
return this;
}

public String execute() {
return "The weather in " + location + " is 72 degrees " + unit;
Expand Down
2 changes: 1 addition & 1 deletion sdk/parents/azure-client-sdk-parent-v2/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@
<dependency>
<groupId>io.clientcore</groupId>
<artifactId>linting-extensions</artifactId>
<version>1.0.0-beta.1</version> <!-- {x-version-update;io.clientcore:linting-extensions;dependency} -->
<version>1.0.0-beta.2</version> <!-- {x-version-update;unreleased_io.clientcore:linting-extensions;dependency} -->
</dependency>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
Expand Down
2 changes: 1 addition & 1 deletion sdk/parents/azure-client-sdk-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@
<dependency>
<groupId>io.clientcore</groupId>
<artifactId>linting-extensions</artifactId>
<version>1.0.0-beta.1</version> <!-- {x-version-update;io.clientcore:linting-extensions;dependency} -->
<version>1.0.0-beta.2</version> <!-- {x-version-update;unreleased_io.clientcore:linting-extensions;dependency} -->
</dependency>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
Expand Down
2 changes: 1 addition & 1 deletion sdk/parents/azure-data-sdk-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
<dependency>
<groupId>io.clientcore</groupId>
<artifactId>linting-extensions</artifactId>
<version>1.0.0-beta.1</version> <!-- {x-version-update;io.clientcore:linting-extensions;dependency} -->
<version>1.0.0-beta.2</version> <!-- {x-version-update;unreleased_io.clientcore:linting-extensions;dependency} -->
</dependency>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
Expand Down
2 changes: 1 addition & 1 deletion sdk/parents/clientcore-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@
<dependency>
<groupId>io.clientcore</groupId>
<artifactId>linting-extensions</artifactId>
<version>1.0.0-beta.1</version> <!-- {x-version-update;io.clientcore:linting-extensions;dependency} -->
<version>1.0.0-beta.2</version> <!-- {x-version-update;unreleased_io.clientcore:linting-extensions;dependency} -->
</dependency>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
Expand Down
Loading