Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes all Mixed Reality SDKs from the Azure SDK for Java repository following the retirement of these services. The removal includes both data-plane (azure-mixedreality-authentication) and management-plane (azure-resourcemanager-mixedreality) client libraries.
Changes:
- Complete removal of the
sdk/mixedreality/directory containing all Mixed Reality SDK packages, tests, samples, and configuration files - Updates to repository-wide configuration files to remove all references to the removed SDKs
- Cleanup of build pipelines, versioning files, BOMs, documentation, and code ownership entries
Reviewed changes
Copilot reviewed 111 out of 159 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
sdk/mixedreality/* |
Entire directory deleted including both authentication and resource manager SDKs |
pom.xml |
Removed mixedreality module from parent POM |
sdk/boms/azure-sdk-bom/pom.xml |
Removed azure-mixedreality-authentication BOM dependency entry |
eng/versioning/version_client.txt |
Removed version entries for both mixedreality packages |
eng/scripts/aggregate_javadoc_configuration.txt |
Removed Mixed Reality Authentication javadoc group |
eng/pipelines/patch_release_client.txt |
Removed mixedreality from patch release list |
.github/CODEOWNERS |
Removed code ownership entry for mixedreality |
sdk/resourcemanager/docs/SINGLE_SERVICE_PACKAGES.md |
Removed mixedreality documentation entry |
|
@jairmyree Are the changes in the azure-sdk-bom fine? I just added it because the referenced package should not be used anymore, but I can also revert the change if you have concerns. |
|
@Azure/azure-sdk-eng Sorry if this hits a few to many people, but are the changes here in the eng/ directory fine? I just don't know if keeping these references around will eventually break things with the packages not being worked on. Should I reverse the changes or just keep it? |
|
@RamonArguelles As you are the only code owner of azure-mixedreality-authenticator. Could you also approve if you agree with removing the SDK? |
|
@weidongxu-microsoft Is it okay to remove the sdk/azure-resourcemanager-mixedreality and change the sdk/resourcemanager/docs? The resource providers on the Azure Portal side are retired so, if this is for creating resources of these types then they shouldn't have any purpose anymore. |
The sdk/azure-resourcemanager-mixedreality lib has not yet to be marked as deprecated. It needs to have a release to mark it as deprecated on package manager. Code can be deleted after the maintenance period. The deprecation process is cross-language. Please follow https://eng.ms/docs/products/azure-developer-experience/retirement/sdk-deprecation The removal of the lib from BOM may not be trivial. CC @jairmyree |
All these mixed reality services are retired and their SDKs can be removed.