escapeNonAscIIPkValueForQueryPlanAndQuery

[xinlian12]

Issue

• When pkValue contains non-ascii characters, the query plan fails with 400:Bad Request
• when pkValue contains non-ascii characters + gateway mode, the query return empty results
• when pre-trigger contains non-ascii characters + gateway mode, the request can fail with 400:Bad Request
• when post-trigger contains non-ascii characters + gateway mode, the request can fail with 400:Bad Request

Root cause

When pkValue is configured in the CosmosQueryRequestOptions, it is being passed as one of the http request headers, same for pre-trigger and post-trigger, and for service Kestrel closes the connection when it sees non-ASCII characters in HTTP headers.

Fixes

• Escape non-ascii character for pkValue
• Escape non-ascii character for pre-trigger
• Escape non-ascii character for post-trigger

[Copilot]

Pull request overview

This pull request has a critical discrepancy between its stated purpose and actual implementation. The PR claims to fix escaping of non-ASCII characters in partition key values for query plans to prevent 400 Bad Request errors, but contains completely unrelated changes.

Changes:

• Modified clientMap usage from getOrDefault to compute in RxDocumentClientImpl.java (contains a bug)
• Improved test cleanup in CosmosDiagnosticsTest.java by using safeCloseSyncClient method consistently

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

File	Description
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java	Changed clientMap update logic from getOrDefault to compute method (but with incorrect postfix increment)
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosDiagnosticsTest.java	Refactored test cleanup to use safeCloseSyncClient utility method for both test clients

[FabianMeiswinkel]

LGTM except for few comments

[FabianMeiswinkel]

LGTM - Thanks!

[xinlian12]

/azp run java - cosmos - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).