Add App Config to Azure Environment by mrm9084 · Pull Request #29393 · Azure/azure-powershell

mrm9084 · 2026-04-10T18:05:05Z

Description

Make it so you can set the App Config environment. Required for new clouds.

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2026-04-10T18:05:09Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

Pull request overview

This PR extends Azure PowerShell’s environment model (Accounts module) to allow configuring Azure App Configuration endpoints (suffix + resource ID) on AzEnvironment, supporting additional/new cloud environments.

Changes:

Added AzureAppConfigurationEndpointSuffix and AzureAppConfigurationEndpointResourceId to PSAzureEnvironment (including PSObject deserialization and equality comparison).
Added corresponding parameters to Add-AzEnvironment and Set-AzEnvironment, and wired them into the endpoint-setting path for the name-based parameter set.
Included the new fields in PSAzureEnvironment.Equals comparisons.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File	Description
`src/Accounts/Authentication.ResourceManager/Models/PSAzureEnvironment.cs`	Adds App Config endpoint properties and includes them in PSObject deserialization + equality logic.
`src/Accounts/Accounts/Environment/SetAzureRMEnvironment.cs`	Adds `Set-AzEnvironment` parameters for App Config endpoints and sets them when bound (name-based path).
`src/Accounts/Accounts/Environment/AddAzureRMEnvironment.cs`	Adds `Add-AzEnvironment` parameters for App Config endpoints and sets them when bound (name-based path).

Copilot · 2026-04-10T18:12:08Z

                       && AzureAttestationServiceEndpointResourceId == other.AzureAttestationServiceEndpointResourceId
                       && AzureAttestationServiceEndpointSuffix == other.AzureAttestationServiceEndpointSuffix
+                       && AzureAppConfigurationEndpointResourceId == other.AzureAppConfigurationEndpointResourceId
+                       && AzureAppConfigurationEndpointSuffix == other.AzureAppConfigurationEndpointSuffix
                       && ContainerRegistryEndpointSuffix == other.ContainerRegistryEndpointSuffix;


Equals now includes the App Configuration fields, but GetHashCode() still uses base.GetHashCode() (identity-based). This violates the Equals/GetHashCode contract and can break hash-based collections. Update GetHashCode() to hash the same fields used by Equals (or adjust/remove the Equals override).

Copilot · 2026-04-10T18:12:08Z

+        [Parameter(ParameterSetName = MetadataParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Dns suffix of Azure App Configuration.")]


This App Configuration parameter is declared for the ARMEndpoint (metadata) parameter set, but the ARMEndpoint branch of ExecuteCmdlet() never applies it to newEnvironment. Passing it alongside -ARMEndpoint will be silently ignored. Either apply it in the metadata branch (e.g., via SetEndpointIfProvided) or remove it from the metadata parameter set.

Suggested change

[Parameter(ParameterSetName = MetadataParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,

HelpMessage = "Dns suffix of Azure App Configuration.")]

Copilot · 2026-04-10T18:12:09Z

+        [Parameter(ParameterSetName = MetadataParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,
+            HelpMessage = "The resource identifier of the Azure App Configuration service that is the recipient of the requested token.")]


Same issue as the suffix parameter: this resourceId parameter is available in the ARMEndpoint parameter set, but the metadata branch of ExecuteCmdlet() doesn’t persist it into the environment, so it has no effect when used with -ARMEndpoint.

Suggested change

[Parameter(ParameterSetName = MetadataParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,

HelpMessage = "The resource identifier of the Azure App Configuration service that is the recipient of the requested token.")]

Copilot · 2026-04-10T18:12:09Z

+                                SetEndpointIfBound(newEnvironment, AzureEnvironment.ExtendedEndpoint.AzureAppConfigurationEndpointSuffix,
+                                    nameof(AzureAppConfigurationEndpointSuffix));
+                                SetEndpointIfBound(newEnvironment, AzureEnvironment.ExtendedEndpoint.AzureAppConfigurationEndpointResourceId,
+                                    nameof(AzureAppConfigurationEndpointResourceId));


Test coverage: EnvironmentCmdletTests.CanCreateEnvironmentWithAllProperties covers many endpoint parameters but not the new App Configuration suffix/resourceId. Please extend that test to assert these endpoints are persisted when bound, to prevent regressions.

Copilot · 2026-04-10T18:12:09Z

+        [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Dns suffix of Azure App Configuration.")]
+        public string AzureAppConfigurationEndpointSuffix { get; set; }
+
+        [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true,
+            HelpMessage = "The resource identifier of the Azure App Configuration service that is the recipient of the requested token.")]


This new parameter can be bound while using the ARMEndpoint parameter set (it isn’t restricted to Name), but the ARMEndpoint branch of ExecuteCmdlet() doesn’t apply it to the environment being created/updated. Either apply it in the metadata branch or restrict it to the Name parameter set to avoid misleading behavior.

Suggested change

[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true,

HelpMessage = "Dns suffix of Azure App Configuration.")]

public string AzureAppConfigurationEndpointSuffix { get; set; }

[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true,

HelpMessage = "The resource identifier of the Azure App Configuration service that is the recipient of the requested token.")]

[Parameter(ParameterSetName = EnvironmentPropertiesParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,

HelpMessage = "Dns suffix of Azure App Configuration.")]

[Parameter(ParameterSetName = MetadataParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,

HelpMessage = "Dns suffix of Azure App Configuration.")]

public string AzureAppConfigurationEndpointSuffix { get; set; }

[Parameter(ParameterSetName = EnvironmentPropertiesParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,

HelpMessage = "The resource identifier of the Azure App Configuration service that is the recipient of the requested token.")]

[Parameter(ParameterSetName = MetadataParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,

HelpMessage = "The resource identifier of the Azure App Configuration service that is the recipient of the requested token.")]

Copilot · 2026-04-10T18:12:10Z

+            HelpMessage = "Dns suffix of Azure App Configuration.")]
+        public string AzureAppConfigurationEndpointSuffix { get; set; }
+
+        [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true,


Same issue as the suffix parameter: -AzureAppConfigurationEndpointResourceId can be specified with -ARMEndpoint, but the metadata branch doesn’t persist it, so it will be ignored.

Suggested change

[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true,

[Parameter(ParameterSetName = EnvironmentPropertiesParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,

Copilot · 2026-04-10T18:12:10Z

+                                SetEndpointIfBound(newEnvironment, AzureEnvironment.ExtendedEndpoint.AzureAppConfigurationEndpointSuffix,
+                                    nameof(AzureAppConfigurationEndpointSuffix));
+                                SetEndpointIfBound(newEnvironment, AzureEnvironment.ExtendedEndpoint.AzureAppConfigurationEndpointResourceId,
+                                    nameof(AzureAppConfigurationEndpointResourceId));


Test coverage: there are existing cmdlet tests asserting endpoint parameters are saved for Add/Set-AzEnvironment, but none cover the new App Configuration suffix/resourceId. Add/extend a test to verify these two endpoints are persisted when provided.

VeryEarly · 2026-04-10T18:12:47Z

/azp run

azure-pipelines · 2026-04-10T18:13:03Z

Azure Pipelines successfully started running 3 pipeline(s).

VeryEarly · 2026-04-10T22:42:41Z

/azp run

azure-pipelines · 2026-04-10T22:42:56Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel

Please remove the parameter from MetadataParameterSet because the parameter set handles only a few endpoints returned by the metadata API.

Besides, please update the change log. Thank you.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/Accounts/Authentication.ResourceManager/Models/PSAzureEnvironment.cs:1

This change updates Equals to include AzureAppConfigurationEndpoint*. If PSAzureEnvironment overrides GetHashCode, it must be updated to include the same fields; otherwise objects that compare equal can produce different hash codes, breaking hash-based collections (e.g., Dictionary, HashSet).

// ----------------------------------------------------------------------------------

Copilot · 2026-04-13T20:21:57Z

        public string AzureAttestationServiceEndpointResourceId { get; set; }

+        [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Dns suffix of Azure App Configuration.")]


Use the standard capitalization "DNS" in help text (currently "Dns").

Suggested change

HelpMessage = "Dns suffix of Azure App Configuration.")]

HelpMessage = "DNS suffix of Azure App Configuration.")]

Copilot · 2026-04-13T20:21:57Z

        public string AzureAttestationServiceEndpointResourceId { get; set; }

+        [Parameter(ParameterSetName = EnvironmentPropertiesParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Dns suffix of Azure App Configuration.")]


Use the standard capitalization "DNS" in help text (currently "Dns").

Copilot · 2026-04-13T20:21:57Z

+                                SetEndpointIfBound(newEnvironment, AzureEnvironment.ExtendedEndpoint.AzureAppConfigurationEndpointSuffix,
+                                    nameof(AzureAppConfigurationEndpointSuffix));
+                                SetEndpointIfBound(newEnvironment, AzureEnvironment.ExtendedEndpoint.AzureAppConfigurationEndpointResourceId,
+                                    nameof(AzureAppConfigurationEndpointResourceId));


The cmdlet now supports setting App Configuration endpoints. Add/extend a test to assert that Set-AzEnvironment persists AzureAppConfigurationEndpointSuffix and AzureAppConfigurationEndpointResourceId onto the environment object (similar to existing endpoint-property assertions), so regressions in parameter binding or endpoint key wiring are caught.

VeryEarly · 2026-04-13T20:42:37Z

/azp run

azure-pipelines · 2026-04-13T20:42:55Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel

Code change looks good. One last thing - could you refresh the help documents by following the steps in https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md

The reference docs for the Add and Set cmdlets are expected to be updated.
Thanks!

mrm9084 · 2026-04-15T17:37:10Z

Code change looks good. One last thing - could you refresh the help documents by following the steps in https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md

The reference docs for the Add and Set cmdlets are expected to be updated. Thanks!

@isra-fel I'm unsure what I'm doing wrong when I generate I only get ProgressAction changes, nothing to do with what I did.

jimmyca15 · 2026-04-15T18:13:37Z


+        [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Dns suffix of Azure App Configuration.")]
+        public string AzureAppConfigurationEndpointSuffix { get; set; }


We shouldn't be including endpoint suffix. It's subject to change, and clients should query endpoint off an app configuration resource rather than build endpoints.

Add App Config to Azure Environment

d04538c

Copilot AI review requested due to automatic review settings April 10, 2026 18:05

Copilot started reviewing on behalf of mrm9084 April 10, 2026 18:07 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Update EnvironmentCmdletTestsExtension.cs

bf00f35

VeryEarly self-assigned this Apr 13, 2026

isra-fel requested changes Apr 13, 2026

View reviewed changes

isra-fel added the act-identity-squad label Apr 13, 2026

isra-fel added this to the Az 15.6.0 (05/05/2026) milestone Apr 13, 2026

review comments

d5b9fc3

Copilot AI review requested due to automatic review settings April 13, 2026 20:14

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Copilot started reviewing on behalf of mrm9084 April 13, 2026 20:27 View session

VeryEarly assigned isra-fel and unassigned VeryEarly Apr 14, 2026

mrm9084 requested a review from isra-fel April 14, 2026 18:34

isra-fel requested changes Apr 15, 2026

View reviewed changes

jimmyca15 reviewed Apr 15, 2026

View reviewed changes

		[Parameter(ParameterSetName = MetadataParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,
		HelpMessage = "Dns suffix of Azure App Configuration.")]

		[Parameter(ParameterSetName = MetadataParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,
		HelpMessage = "The resource identifier of the Azure App Configuration service that is the recipient of the requested token.")]

	[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true,
	[Parameter(ParameterSetName = EnvironmentPropertiesParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true,

Conversation

mrm9084 commented Apr 10, 2026

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Apr 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

VeryEarly commented Apr 10, 2026

Uh oh!

azure-pipelines bot commented Apr 10, 2026

Uh oh!

VeryEarly commented Apr 10, 2026

Uh oh!

azure-pipelines bot commented Apr 10, 2026

Uh oh!

isra-fel left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

VeryEarly commented Apr 13, 2026

Uh oh!

azure-pipelines bot commented Apr 13, 2026

Uh oh!

isra-fel left a comment

Choose a reason for hiding this comment

Uh oh!

mrm9084 commented Apr 15, 2026

Uh oh!

jimmyca15 Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants