Migrate StorageAction module to tsp by Pan-Qi · Pull Request #29136 · Azure/azure-powershell

Pan-Qi · 2026-02-04T15:48:12Z

Description

announcement PR

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2026-02-04T15:48:19Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

github-actions · 2026-02-05T12:43:41Z

To the author of the pull request,
This PR was labeled "Contains Breaking Change" because breaking changes have been detected by the static analysis pipeline.

According to our policy, breaking changes can only take place during major release and they must be preannounced.
Please follow our guide on the detailed steps.
Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-05T12:57:41Z

src/StorageAction/StorageAction.Autorest/Properties/AssemblyInfo.cs

 // Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+// Changes may cause incorrect behavior and will be lost if the code is regenerated.
+// Copyright (c) Microsoft Corporation. All rights reserved.


Duplicate copyright notice at lines 1 and 4. Remove the duplicate copyright header to avoid confusion.

Pan-Qi · 2026-02-06T00:25:11Z

/azp run

azure-pipelines · 2026-02-06T00:25:28Z

Azure Pipelines successfully started running 3 pipeline(s).

…ageaction-with-tsp

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Copilot · 2026-02-06T05:45:03Z

src/StorageAction/StorageAction.Autorest/Properties/AssemblyInfo.cs

 // Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+// Changes may cause incorrect behavior and will be lost if the code is regenerated.
+// Copyright (c) Microsoft Corporation. All rights reserved.


The file contains a duplicate copyright header at the beginning. Lines 1-3 show one copyright header (MIT License), and lines 4-13 show another (Apache License 2.0). This appears to be an error from the code generation process. Only one copyright header should be present at the start of the file.

Copilot · 2026-02-06T05:45:03Z

src/StorageAction/StorageAction/ChangeLog.md

        - Additional information about change #1
 -->
 ## Upcoming Release
+* Migrated to typespec


The ChangeLog entry "Migrated to typespec" is too technical for end users. According to repository conventions (guideline 1000003), ChangeLog entries should be written from the user's perspective and explain what changed and how it affects their usage. This is an internal implementation detail that doesn't provide meaningful information to PowerShell users. Consider describing the user-facing impact, such as new features, improvements, or note that this is a non-breaking internal modernization if there are no user-visible changes.

isra-fel

Got some questions

isra-fel · 2026-02-09T04:27:52Z

src/StorageAction/StorageAction.Autorest/tspconfig.yaml

+    service-dir: "src"
+    emitter-output-dir: "{output-dir}/{service-dir}/StorageAction/StorageAction.Autorest"
+    clear-output-folder: true
+    debug: true


Should we not enable debug in production?

this works similar as autorest --debug and will generate comments of subject/variant/prefix etc,. should be removed in order to reduce size of generated code slightly @Pan-Qi

isra-fel · 2026-02-09T04:29:39Z

tools/StaticAnalysis/Exceptions/Az.StorageAction/BreakingChangeIssues.csv

@@ -0,0 +1,4 @@
+"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
+"Az.StorageAction","Get-AzStorageActionTask","Get-AzStorageActionTask","0","3000","The type of property 'IdentityUserAssignedIdentity' of type 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IStorageTask' has changed from 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IUserAssignedIdentities' to 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IManagedServiceIdentityUserAssignedIdentities'.","Change the type of property 'IdentityUserAssignedIdentity' back to 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IUserAssignedIdentities'."
+"Az.StorageAction","New-AzStorageActionTask","New-AzStorageActionTask","0","3000","The type of property 'IdentityUserAssignedIdentity' of type 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IStorageTask' has changed from 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IUserAssignedIdentities' to 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IManagedServiceIdentityUserAssignedIdentities'.","Change the type of property 'IdentityUserAssignedIdentity' back to 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IUserAssignedIdentities'."


Is this breaking change expected in the migration to TSP, or should we mitigate it instead?

these breaking changes came from referring common-types v5 -> v6, behavior should be expected

github-actions · 2026-02-09T08:18:23Z

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

Migrate StorageAction module to tsp

a30a636

Copilot AI review requested due to automatic review settings February 4, 2026 15:48

Copilot started reviewing on behalf of Pan-Qi February 4, 2026 15:50 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

suppress breaking change

39d2961

Pan-Qi added the Contains Breaking Change This PR contains breaking change label Feb 5, 2026

changelog

b5e44fd

Copilot AI review requested due to automatic review settings February 5, 2026 12:46

Copilot started reviewing on behalf of Pan-Qi February 5, 2026 12:49 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

Pan-Qi mentioned this pull request Feb 6, 2026

StorageAction tsp migration BC announcement #29141

Merged

6 tasks

Merge remote-tracking branch 'origin/main' into Bernard-generate-stor…

905a590

…ageaction-with-tsp

Pan-Qi marked this pull request as ready for review February 6, 2026 05:35

Copilot AI review requested due to automatic review settings February 6, 2026 05:35

Copilot started reviewing on behalf of Pan-Qi February 6, 2026 05:37 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

isra-fel added this to the Az 16.0.0 (06/02/2026) milestone Feb 9, 2026

isra-fel reviewed Feb 9, 2026

View reviewed changes

isra-fel added the TypeSpec Module generated from TypeSpec label Feb 9, 2026

isra-fel assigned VeryEarly Feb 9, 2026

isra-fel added the needs-review label Feb 9, 2026

VeryEarly added Do Not Merge 🚫 Do Not Close 🚫 Can be used for PR that might by closed otherwise in Repo Cleanup. Breaking change PR reviewed Add this label after a PR with breaking change has been reviewed and approved. and removed needs-review labels Feb 9, 2026

Conversation

Pan-Qi commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Feb 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Pan-Qi commented Feb 6, 2026

Uh oh!

azure-pipelines bot commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

isra-fel left a comment

Choose a reason for hiding this comment

Uh oh!

isra-fel Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

VeryEarly Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

isra-fel Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

VeryEarly Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Pan-Qi commented Feb 4, 2026 •

edited

Loading