-
Notifications
You must be signed in to change notification settings - Fork 287
Update CODEOWNERS for azure.ai.agents #7722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ | |
| /cli/installer/ @jongio @wbreza @danieljurek @vhvb1989 @tg-msft @rajeshkamal5050 | ||
|
|
||
| # ── CLI extensions (AI) ────────────────────────────────────────────────────── | ||
| /cli/azd/extensions/azure.ai.agents/ @jongio @wbreza @vhvb1989 @hemarina @weikanglim @JeffreyCA @tg-msft @rajeshkamal5050 @trangevi @trrwilson @therealjohn | ||
| /cli/azd/extensions/azure.ai.agents/ @trangevi @trrwilson @therealjohn @glharper | ||
|
trangevi marked this conversation as resolved.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I prefer to keep azd folks on this and add foundry folks instead of remove azd
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My main concern is about broader directional understanding for the extension. Code review from the azd team is valuable and desirable, but as more and more things get added, I would assume that it won't be your role to make sure that changes are following the desired direction for the extension, more so for azd all up. So I'm concerned that a change will be proposed, reviewed and approved by azd folks, and merged, before foundry folks are even aware of it (I already saw it with one of Glenn's PRs, which got me thinking of this). Since GH doesn't have a concept of required and optional reviewers, I couldn't think of another way to address the concern other than removing azd folks as codeowners, and instead manually requesting reviews from you, while leaving foundry folks as the final sign off. If there's a better way to accomplish this I'm very much open to it, as I definitely don't want to lose the current collaboration. |
||
| /cli/azd/extensions/azure.ai.finetune/ @jongio @wbreza @vhvb1989 @hemarina @weikanglim @JeffreyCA @tg-msft @rajeshkamal5050 @trangevi @achauhan-scc @kingernupur @rabollin @saanikaguptamicrosoft | ||
| /cli/azd/extensions/azure.ai.models/ @jongio @wbreza @vhvb1989 @hemarina @weikanglim @JeffreyCA @tg-msft @rajeshkamal5050 @trangevi @achauhan-scc @kingernupur @rabollin @saanikaguptamicrosoft | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.