Conversation
FumingZhang
requested review from
NoriZC,
teresaritorto and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens az aks get-credentials kubeconfig persistence in acs/custom.py by preventing symlink-based write redirection and reducing risk of partial/corrupted kubeconfig writes.
Changes:
- Rejects kubeconfig paths that are symbolic links with a clear
CLIError. - Switches kubeconfig write to a temp-file +
os.replace()atomic replace pattern in the target directory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Queued live test to validate the change, test passed!
|
FumingZhang
force-pushed
the
fuming/aks-get-credentials-fix
branch
from
9298539 to
71e171d
Compare
yanzhudd
approved these changes
Apr 10, 2026
yanzhudd
changed the title
az aks get-credentials: Harden kubeconfig write with symlink check and atomic replaceaz aks get-credentials: Harden kubeconfig write with symlink check and atomic replace
Contributor
|
I just updated the tile from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks get-credentialsDescription
merge_kubernetes_configurations()writes the merged kubeconfig directly viaopen(path, 'w+')without checking for symlinks or ensuring atomicity. This means:This change adds a symlink check that rejects symlink paths with a clear error, and replaces the direct write with an atomic temp-file-then-
os.replace()pattern in the same directory.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.