{CI} rm _vendor/bin from setuptools for rpm #32686
Conversation
DanielMicrosoft
requested review from
bebound,
calvinhzy,
jiasli,
kairu-ms and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @DanielMicrosoft, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Pan-Qi,
jsntcy and
yonzhan
There was a problem hiding this comment.
Pull request overview
This PR adds a cleanup step to the RPM build process to remove vendored binaries from setuptools that contain foreign shebangs, which cause RPM dependency issues during package building.
Changes:
- Add a removal step for setuptools/_vendor/bin directory with appropriate error handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The pipeline log will be deleted, please copy the error info in the PR description. Since the issue leads from setuptools, please create a issue for them. If they fix it, we don't need to change our code. |
| rm %{buildroot}%{cli_lib_dir}/pyvenv.cfg | ||
|
|
||
| # Remove vendored binaries with foreign shebangs that cause RPM dependency issues | ||
| # Use || true to not fail if path doesn't exist |
There was a problem hiding this comment.
man rm output shows that this particular case is already covered. If there are any other issues, || true will hide them.
-f, --force
ignore nonexistent files and arguments, never prompt
5 participants
Related command
Description
Addressing issue that surfaced here in azure-cli
batched CIpipelines.Output of error from pipelines:
File in question was added to setuptools here
Note, GH issue has been lodged with
setuptoolsrepo: pypa/setuptools#5159This PR may not be necessary if a fix is applied on setuptools within the next few days, otherwise we may need the workaround in this PR.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.