Quantum: update create new workspace template, fix e2e tests#9711
Quantum: update create new workspace template, fix e2e tests#9711rigidit wants to merge 9 commits intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @rigidit, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
|
Hi @rigidit Release SuggestionsModule: quantum
Notes
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Quantum extension to better support secure, managed-identity-based storage access during workspace creation and fixes storage selection behavior during job submission.
Changes:
- Update the workspace creation ARM template to disable shared-key access and add RBAC assignments needed for user delegation SAS scenarios.
- Fix job submission to pass an explicit storage connection string through to the Workspace client (instead of relying on linked-storage discovery).
- Bump extension version to
1.0.0b13and add release notes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/quantum/setup.py |
Bumps extension package version to 1.0.0b13. |
src/quantum/azext_quantum/operations/templates/create-workspace-and-assign-role.json |
Disables shared-key access on the storage account and adds an additional storage RBAC role assignment. |
src/quantum/azext_quantum/operations/job.py |
Passes storage into the Workspace constructor so explicit connection strings are honored. |
src/quantum/HISTORY.rst |
Adds 1.0.0b13 changelog entry describing the storage and job submission changes. |
src/quantum/azext_quantum/operations/templates/create-workspace-and-assign-role.json
Show resolved
Hide resolved
src/quantum/azext_quantum/operations/templates/create-workspace-and-assign-role.json
Outdated
Show resolved
Hide resolved
…ith enabled/disabled access keys on linked storage
…can access the storage account
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.