Skip to content

Quantum: update create new workspace template, fix e2e tests#9711

Open
rigidit wants to merge 9 commits intoAzure:mainfrom
rigidit:users/rigidit/ws-create
Open

Quantum: update create new workspace template, fix e2e tests#9711
rigidit wants to merge 9 commits intoAzure:mainfrom
rigidit:users/rigidit/ws-create

Conversation

@rigidit
Copy link
Copy Markdown
Contributor

@rigidit rigidit commented Mar 23, 2026

Description

  • Updated workspace create command to support job submissions with disabled access keys on linked storage account
  • Updated new storage account to be v2 in workspace creation because of the retirement of General-Purpose v1 (GPv1) storage accounts in October 13, 2026
  • Added new e2e test, fixed test_get_provider and test_submit e2e tests

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Mar 23, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @rigidit,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 23, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Auto-Assign Auto assign by bot labels Mar 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 23, 2026

@github-actions
Copy link
Copy Markdown
Contributor

Hi @rigidit

Release Suggestions

Module: quantum

  • Please log updates into to src/quantum/HISTORY.rst
  • Update VERSION to 1.0.0b13 in src/quantum/setup.py

Notes

@rigidit rigidit marked this pull request as ready for review March 24, 2026 00:15
Copilot AI review requested due to automatic review settings March 24, 2026 00:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Quantum extension to better support secure, managed-identity-based storage access during workspace creation and fixes storage selection behavior during job submission.

Changes:

  • Update the workspace creation ARM template to disable shared-key access and add RBAC assignments needed for user delegation SAS scenarios.
  • Fix job submission to pass an explicit storage connection string through to the Workspace client (instead of relying on linked-storage discovery).
  • Bump extension version to 1.0.0b13 and add release notes.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/quantum/setup.py Bumps extension package version to 1.0.0b13.
src/quantum/azext_quantum/operations/templates/create-workspace-and-assign-role.json Disables shared-key access on the storage account and adds an additional storage RBAC role assignment.
src/quantum/azext_quantum/operations/job.py Passes storage into the Workspace constructor so explicit connection strings are honored.
src/quantum/HISTORY.rst Adds 1.0.0b13 changelog entry describing the storage and job submission changes.

@yonzhan yonzhan requested a review from necusjz March 24, 2026 00:32
@rigidit rigidit marked this pull request as draft March 24, 2026 03:18
@rigidit rigidit requested a review from Copilot April 7, 2026 18:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

@rigidit rigidit marked this pull request as ready for review April 7, 2026 19:40
@rigidit rigidit changed the title Quantum: update create new workspace template, fix storage handling bug in job submission Quantum: update create new workspace template, fix e2e tests Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants