{IoT} Adds IoT extension v0.28.0 #9547
Conversation
ketkimnaik
requested review from
calvinhzy,
jiasli,
jsntcy,
kairu-ms,
necusjz,
wangzelin007 and
zhoxing-ms
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @ketkimnaik, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Pull request overview
This PR adds version 0.28.0 of the Azure IoT CLI extension to the extension index. The release includes updates to Python version support (adding Python 3.13), a new minimum CLI core version requirement (2.67.0), and the addition of the azure-eventhub dependency.
Changes:
- Adds azure-iot extension version 0.28.0 with updated Python support and dependencies
- Introduces "azext.isPreview": false field for stable release metadata
- Updates minimum Azure CLI core version to 2.67.0
| "run_requires": [ | ||
| { | ||
| "requires": [ | ||
| "azure-core (<2.0.0,>=1.24.0)", | ||
| "azure-core<2.0.0,>=1.24.0", | ||
| "azure-eventhub (~=5.15.0)", | ||
| "azure-eventhub~=5.15.0", | ||
| "azure-identity (<1.18.0,>=1.6.1)", | ||
| "azure-identity<1.18.0,>=1.6.1", | ||
| "azure-iot-device (~=2.11)", | ||
| "azure-iot-device~=2.11", | ||
| "azure-mgmt-core (<2.0.0,>=1.3.0)", | ||
| "azure-mgmt-core<2.0.0,>=1.3.0", | ||
| "azure-storage-blob (<13.0.0,>=12.14.0)", | ||
| "azure-storage-blob<13.0.0,>=12.14.0", | ||
| "jsonschema (~=3.2.0)", | ||
| "jsonschema~=3.2.0", | ||
| "msrest (>=0.6.21)", | ||
| "msrest>=0.6.21", | ||
| "msrestazure (<2.0.0,>=0.6.3)", | ||
| "msrestazure<2.0.0,>=0.6.3", | ||
| "packaging (>=23.2)", | ||
| "packaging>=23.2", | ||
| "tomli (~=2.0)", | ||
| "tomli-w (~=1.0)", | ||
| "tomli-w~=1.0", | ||
| "tomli~=2.0", | ||
| "tqdm (~=4.62)", | ||
| "tqdm~=4.62", | ||
| "treelib (~=1.6)", | ||
| "treelib~=1.6" | ||
| ] | ||
| } | ||
| ], |
There was a problem hiding this comment.
The run_requires array is missing additional entries for the uamqp extra. Comparing with other versions (v0.26.0 at lines 33007-33018, v0.27.0 at lines 33101-33112, and v0.30.0b1 at lines 33198-33209), the run_requires should include three objects: the base requires, an entry with "extra": "uamqp", and an entry with "environment": "extra == "uamqp"". This version only has one object with the base requires, which is incomplete.
| "extras": [], | ||
| "generator": "bdist_wheel (0.30.0)", | ||
| "license": "MIT", | ||
| "license_file": "LICENSE", | ||
| "metadata_version": "2.0", | ||
| "name": "azure-iot", | ||
| "requires_python": ">=3.9", | ||
| "run_requires": [ | ||
| { | ||
| "requires": [ | ||
| "azure-core (<2.0.0,>=1.24.0)", | ||
| "azure-core<2.0.0,>=1.24.0", | ||
| "azure-eventhub (~=5.15.0)", | ||
| "azure-eventhub~=5.15.0", | ||
| "azure-identity (<1.18.0,>=1.6.1)", | ||
| "azure-identity<1.18.0,>=1.6.1", | ||
| "azure-iot-device (~=2.11)", | ||
| "azure-iot-device~=2.11", | ||
| "azure-mgmt-core (<2.0.0,>=1.3.0)", | ||
| "azure-mgmt-core<2.0.0,>=1.3.0", | ||
| "azure-storage-blob (<13.0.0,>=12.14.0)", | ||
| "azure-storage-blob<13.0.0,>=12.14.0", | ||
| "jsonschema (~=3.2.0)", | ||
| "jsonschema~=3.2.0", | ||
| "msrest (>=0.6.21)", | ||
| "msrest>=0.6.21", | ||
| "msrestazure (<2.0.0,>=0.6.3)", | ||
| "msrestazure<2.0.0,>=0.6.3", | ||
| "packaging (>=23.2)", | ||
| "packaging>=23.2", | ||
| "tomli (~=2.0)", | ||
| "tomli-w (~=1.0)", | ||
| "tomli-w~=1.0", | ||
| "tomli~=2.0", | ||
| "tqdm (~=4.62)", | ||
| "tqdm~=4.62", | ||
| "treelib (~=1.6)", | ||
| "treelib~=1.6" | ||
| ] | ||
| } | ||
| ], |
There was a problem hiding this comment.
The "extras" field is missing from the metadata. Looking at other versions of this extension (v0.26.0 at line 32967-32968, v0.27.0 at line 33061-33062, and v0.30.0b1 at line 33125-33126), they all include an "extras" field with the value ["uamqp"], and corresponding additional run_requires entries for the uamqp extra. This version should include the same structure to maintain consistency across versions.
microsoft-github-policy-service
bot
requested review from
yanzhudd and
yonzhan
4 participants
Notes for this release can be found here:
https://github.com/Azure/azure-iot-cli-extension/releases/tag/v0.28.0
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.