-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Artifact signing extension added #9533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @amritas, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @amritas
|
|
@amritas please do not try to modify two modules within the same PR, as this may cause some unpredictable issues from ci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces a new artifact-signing Azure CLI extension to replace the deprecated trustedsigning extension. The change implements a breaking rename of the extension while maintaining backward compatibility through deprecation notices.
Changes:
- Added new
artifact-signingextension (version 1.0.0) with full command implementation - Deprecated
trustedsigningextension commands (version bumped to 1.0.0b3) with redirect toartifact-signing - Updated service metadata in
service_name.jsonwith URL corrections and formatting fixes
Reviewed changes
Copilot reviewed 36 out of 37 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/trustedsigning/setup.py | Version bump from 1.0.0b2 to 1.0.0b3 |
| src/trustedsigning/azext_trustedsigning/commands.py | Added deprecation configuration redirecting to artifact-signing |
| src/trustedsigning/README.md | Added deprecation notice at the top |
| src/trustedsigning/HISTORY.rst | Updated changelog with version 1.0.0b3 and 1.0.0b2 entries |
| src/service_name.json | Fixed formatting, updated trustedsigning URL, added artifact-signing entry |
| src/artifact-signing/setup.py | New extension setup with version 1.0.0 |
| src/artifact-signing/azext_artifact_signing/* | Complete new extension implementation including commands, tests, and AAZ definitions |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.