Skip to content

Conversation

@amritas
Copy link
Contributor

@amritas amritas commented Jan 19, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @amritas,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 19, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jan 19, 2026

Hi @amritas

⚠️ Release Requirements

Module: artifact-signing

  • ⚠️ Please update VERSION to be 1.0.0b1 in src/artifact-signing/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 19, 2026
@yonzhan yonzhan requested a review from kairu-ms January 20, 2026 00:26
@yonzhan yonzhan requested a review from jsntcy January 20, 2026 00:26
@jsntcy jsntcy requested a review from necusjz January 20, 2026 06:29
@necusjz
Copy link
Member

necusjz commented Jan 20, 2026

@amritas please do not try to modify two modules within the same PR, as this may cause some unpredictable issues from ci.

@amritas amritas marked this pull request as ready for review January 21, 2026 04:36
Copilot AI review requested due to automatic review settings January 21, 2026 04:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces a new artifact-signing Azure CLI extension to replace the deprecated trustedsigning extension. The change implements a breaking rename of the extension while maintaining backward compatibility through deprecation notices.

Changes:

  • Added new artifact-signing extension (version 1.0.0) with full command implementation
  • Deprecated trustedsigning extension commands (version bumped to 1.0.0b3) with redirect to artifact-signing
  • Updated service metadata in service_name.json with URL corrections and formatting fixes

Reviewed changes

Copilot reviewed 36 out of 37 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/trustedsigning/setup.py Version bump from 1.0.0b2 to 1.0.0b3
src/trustedsigning/azext_trustedsigning/commands.py Added deprecation configuration redirecting to artifact-signing
src/trustedsigning/README.md Added deprecation notice at the top
src/trustedsigning/HISTORY.rst Updated changelog with version 1.0.0b3 and 1.0.0b2 entries
src/service_name.json Fixed formatting, updated trustedsigning URL, added artifact-signing entry
src/artifact-signing/setup.py New extension setup with version 1.0.0
src/artifact-signing/azext_artifact_signing/* Complete new extension implementation including commands, tests, and AAZ definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants