Skip to content

Conversation

@Ptnan7
Copy link
Member

@Ptnan7 Ptnan7 commented Jan 19, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings January 19, 2026 04:18
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 19, 2026

❌Azure CLI Extensions Breaking Change Test
❌front-door
rule cmd_name rule_message suggest_message
1007 - ParaRemove network front-door waf-policy managed-rules exclusion list cmd network front-door waf-policy managed-rules exclusion list removed parameter rule_group_id please add back parameter rule_group_id for cmd network front-door waf-policy managed-rules exclusion list
1007 - ParaRemove network front-door waf-policy managed-rules exclusion list cmd network front-door waf-policy managed-rules exclusion list removed parameter rule_id please add back parameter rule_id for cmd network front-door waf-policy managed-rules exclusion list
1007 - ParaRemove network front-door waf-policy managed-rules exclusion list cmd network front-door waf-policy managed-rules exclusion list removed parameter rule_set_type please add back parameter rule_set_type for cmd network front-door waf-policy managed-rules exclusion list
1007 - ParaRemove network front-door waf-policy managed-rules override list cmd network front-door waf-policy managed-rules override list removed parameter rule_set_type please add back parameter rule_set_type for cmd network front-door waf-policy managed-rules override list
1007 - ParaRemove network front-door waf-policy rule create cmd network front-door waf-policy rule create removed parameter _cache please add back parameter _cache for cmd network front-door waf-policy rule create
1007 - ParaRemove network front-door waf-policy rule delete cmd network front-door waf-policy rule delete removed parameter _cache please add back parameter _cache for cmd network front-door waf-policy rule delete
1007 - ParaRemove network front-door waf-policy rule list cmd network front-door waf-policy rule list removed parameter _cache please add back parameter _cache for cmd network front-door waf-policy rule list
1007 - ParaRemove network front-door waf-policy rule match-condition add cmd network front-door waf-policy rule match-condition add removed parameter _cache please add back parameter _cache for cmd network front-door waf-policy rule match-condition add
1007 - ParaRemove network front-door waf-policy rule match-condition list cmd network front-door waf-policy rule match-condition list removed parameter _cache please add back parameter _cache for cmd network front-door waf-policy rule match-condition list
1007 - ParaRemove network front-door waf-policy rule match-condition remove cmd network front-door waf-policy rule match-condition remove removed parameter _cache please add back parameter _cache for cmd network front-door waf-policy rule match-condition remove
1007 - ParaRemove network front-door waf-policy rule show cmd network front-door waf-policy rule show removed parameter _cache please add back parameter _cache for cmd network front-door waf-policy rule show
1007 - ParaRemove network front-door waf-policy rule update cmd network front-door waf-policy rule update removed parameter _cache please add back parameter _cache for cmd network front-door waf-policy rule update

@azure-client-tools-bot-prd
Copy link

Hi @Ptnan7,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 19, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @Ptnan7

Release Suggestions

Module: front-door

  • Please log updates into to src/front-door/HISTORY.rst
  • Update VERSION to 2.0.0 in src/front-door/setup.py

Notes

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated --defer flag functionality from Azure Front Door WAF policy commands and refactors command registration to use class-based commands (AAZ pattern). It also adds new managed rule definition commands.

Changes:

  • Removed --defer flag from all WAF policy custom rule and match condition commands
  • Refactored command registration from function-based to class-based AAZ pattern
  • Added new managed rule definition list command
  • Updated tests to work without defer flag, requiring match conditions at rule creation
  • Updated minimum CLI version to 2.75.0

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test_waf_scenarios.py Removed --defer flag usage, updated tests to provide required match conditions during rule creation, adjusted error messages and test assertions
commands.py Refactored from function-based to class-based command registration using AAZ pattern
azext_metadata.json Updated minimum CLI core version from 2.70.0 to 2.75.0
managed_rule_definition/* Added new AAZ-generated files for managed rule definition list command
*.yaml (recordings) Updated test recordings with new timestamps and API version changes

@necusjz
Copy link
Member

necusjz commented Jan 19, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Jan 20, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants