-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{FrontDoor} Add sub command for waf #9532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @Ptnan7, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Ptnan7 Release SuggestionsModule: front-door
Notes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the deprecated --defer flag functionality from Azure Front Door WAF policy commands and refactors command registration to use class-based commands (AAZ pattern). It also adds new managed rule definition commands.
Changes:
- Removed
--deferflag from all WAF policy custom rule and match condition commands - Refactored command registration from function-based to class-based AAZ pattern
- Added new managed rule definition list command
- Updated tests to work without defer flag, requiring match conditions at rule creation
- Updated minimum CLI version to 2.75.0
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_waf_scenarios.py | Removed --defer flag usage, updated tests to provide required match conditions during rule creation, adjusted error messages and test assertions |
| commands.py | Refactored from function-based to class-based command registration using AAZ pattern |
| azext_metadata.json | Updated minimum CLI core version from 2.70.0 to 2.75.0 |
| managed_rule_definition/* | Added new AAZ-generated files for managed rule definition list command |
| *.yaml (recordings) | Updated test recordings with new timestamps and API version changes |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.