refactor: Split ConnectorFunctions.cs into per-connector files (#19)#41
Merged
refactor: Split ConnectorFunctions.cs into per-connector files (#19)#41
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Refactors the DirectConnector Azure Functions sample by splitting the legacy monolithic ConnectorFunctions.cs into separate per-connector function classes (Office365, SharePoint, Teams), aligning with the repository’s established “one file per connector” pattern.
Changes:
- Added
Office365Functions.cscontaining Office365-related HTTP-triggered functions (including trigger callback handling). - Added
SharePointFunctions.cscontaining SharePoint list/folder/file download/upload functions. - Added
TeamsFunctions.cscontaining Teams listing/channel/message functions and message posting. - Removed the legacy combined
ConnectorFunctions.cs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| DirectConnector/Office365Functions.cs | Introduces Office365-specific Azure Functions class extracted from the previous monolith. |
| DirectConnector/SharePointFunctions.cs | Introduces SharePoint-specific Azure Functions class extracted from the previous monolith. |
| DirectConnector/TeamsFunctions.cs | Introduces Teams-specific Azure Functions class extracted from the previous monolith. |
| DirectConnector/ConnectorFunctions.cs | Deletes the legacy combined functions file after extraction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split the monolithic \ConnectorFunctions.cs\ (1194 lines) into three per-connector files, matching the existing project convention (see \OneDriveFunctions.cs, \MsGraphFunctions.cs, \ArmFunctions.cs).
Changes
What did NOT change
Verification
Closes #19