Closed
Conversation
Companion to Connectors-NET-SDK#102
There was a problem hiding this comment.
Pull request overview
Updates XML documentation comments in the DirectConnector samples to reflect the SDK rename from ConnectorPageable to AsyncPageable, aligning the samples’ docs with the newer paging abstraction referenced in the companion SDK PRs.
Changes:
- Updated Teams channel messages pagination remark to reference
AsyncPageable. - Updated Azure Log Analytics subscriptions pagination summary to reference
AsyncPageable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| DirectConnector/ConnectorFunctions.cs | Updates XML remarks for the Teams messages paging example to reference AsyncPageable. |
| DirectConnector/AzureLogAnalyticsFunctions.cs | Updates XML summary comment for the subscriptions paging example to reference AsyncPageable. |
| /// <remarks> | ||
| /// Demonstrates <see cref="IAsyncEnumerable{T}"/> pagination: <c>GetMessagesFromChannelAsync</c> | ||
| /// returns a <c>ConnectorPageable</c> that follows <c>@odata.nextLink</c> automatically. | ||
| /// returns a <c>AsyncPageable</c> that follows <c>@odata.nextLink</c> automatically. |
Member
Author
|
Closing — superseded by #40 which consolidates all SDK v0.9.0-preview.1 breaking changes, namespace migrations, and new features into a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update XML doc comments referencing \ConnectorPageable\ to \AsyncPageable.
Companion to Azure/Connectors-NET-SDK#102 / Azure/Connectors-NET-SDK#105.