Introduced vSys (deviceCustomString3) and DeviceName into the summary rules for Palo Alto Networks.#13585
Open
0xrick-dev wants to merge 4 commits intoAzure:masterfrom
Open
Introduced vSys (deviceCustomString3) and DeviceName into the summary rules for Palo Alto Networks.#135850xrick-dev wants to merge 4 commits intoAzure:masterfrom
0xrick-dev wants to merge 4 commits intoAzure:masterfrom
Conversation
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Contributor
|
Hi @0xrick-dev Kindly add the testing screenshot for reference. Thanks! |
Contributor
|
Hi @0xrick-dev Kindly review the comments provided above. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s):
Updated the summary rule to include vSys (deviceCustomString3) and DeviceName in the aggregation logic to ensure proper device-level distinction.
Reason for Change(s):
Addresses false positives caused by overlapping subnets and network ranges, where multiple devices were previously summarized incorrectly.
Using DeviceCustomString3 and DeviceName resolves incorrect correlations and improves detection accuracy.
Version Updated:
Yes
Required for Detections/Analytic Rule templates.
Testing Completed:
Yes
Checked that the validations are passing and have addressed any issues that are present:
Yes