-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add meshcloud meshStack events log connector solution #13324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@microsoft-github-policy-service agree company="meshcloud GmbH" |
|
Hi @grubmeshi, please review the error message regarding the logo validation failure and address it. Additionally, you need to generate the package with version 3.0.0, so please repackage the solution using the V3 tool - https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.…. |
this assumes that the Tools/Create-Azure-Sentinel-Solution/V3/createSolutionV3.ps1 is run with the repo root as working directory
local command from repo root (on Linux machine): $ pwsh Tools/Create-Azure-Sentinel-Solution/V3/createSolutionV3.ps1 -SolutionDataFolderPath ./Solutions/meshStack/Data
977000f to
7ef270d
Compare
@v-shukore Thanks for having a look at my changes. I've addressed them all I think. I've also successfully managed to package it on my Linux machine with a little fix to support relative Let me know what's missing until this can be finally merged. |
Change(s):
Reason for Change(s):
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
mainTemplate.jsonworks. Automatic packaging is TODO.