Skip to content

Add azd-service-name tag to function app parameters #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vhvb1989 wants to merge 1 commit into from
Closed

Add azd-service-name tag to function app parameters #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion infra/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ module api './app/api.bicep' = {
params: {
name: functionAppName
location: location
tags: tags
tags: union(tags, {
'azd-service-name': 'api'
})
Comment on lines +109 to +111
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra/app/api.bicep already applies the azd-service-name tag to the Function App resource (tags: union(tags, { 'azd-service-name': serviceName })). Adding the same tag again here makes the source of truth unclear and can drift if serviceName is ever overridden. Consider either (a) reverting to tags: tags here and relying on api.bicep, or (b) passing an explicit serviceName param from main.bicep and letting api.bicep set the tag once.

Suggested change
tags: union(tags, {
'azd-service-name': 'api'
})
tags: tags

Copilot uses AI. Check for mistakes.
applicationInsightsName: monitoring.outputs.name
appServicePlanId: appServicePlan.outputs.resourceId
runtimeName: 'node'
Expand Down