Pull latest dotnet 6.0-focal image and add Microsoft Signing Keys to avoid expired signature causing deployment failure#8
Open
seantleonard wants to merge 8 commits intoAzure-Samples:mainfrom
Conversation
…id signing expiration. Image pulled was `0-6.0-focal` from oct 3, 2023
add git attributes for sh line endings
Contributor
Author
|
Merge #9 in first to see if fixing the pre-req scripts (which also include importing microsoft signing keys) fixes the root of the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #7
Per #7, I get a deployment error when trying to use the sample because the sample's dockerfile refers to an old image from October 3, 2023:
Essentially: hardcoding the image to use
0-6.0-focalpull that specific image. Removing the prefix0-allows the latest container image to be pulled for dotnet 6 on Ubuntu 20.04 (Focal).And should be pulling latest:
Also imports Microsoft signing keys to fix gpg error
Background on failure
The deployment errors out seemingly due to docker-outside-of-docker. Not sure if this is the cause or just a symptom of the failure.
It looks like the docker outside of docker feature install.sh only imports the Microsoft signing keys if Moby is used:
https://github.com/devcontainers/features/blob/414d3450434b9072f01afe80cab226c60088224a/src/docker-outside-of-docker/install.sh#L215-L229
I do notice the Sample project I'm using doesn't provide a Moby property, which per docker outside of docker docs, moby should be true by default. Not sure why the key setup isn't working.
azure-sql-library-app-blazor/.devcontainer/devcontainer.json
Lines 59 to 61 in 0a1ba8c
Does this introduce a breaking change?
By staying at .net 6 and Ubuntu 20.04 (focal), this is a non-breaking change.
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test