feat: add forfeit_game function and contract review#234
Open
critesjosh wants to merge 1 commit intonextfrom
Open
feat: add forfeit_game function and contract review#234critesjosh wants to merge 1 commit intonextfrom
critesjosh wants to merge 1 commit intonextfrom
Conversation
Add forfeit functionality allowing players to forfeit in-progress games: - Add forfeit_game public function to main.nr - Add get_opponent helper method to Race struct - Add comprehensive tests for forfeit scenarios - Include contract security review in REVIEW.md Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forfeit_gamepublic function allowing players to forfeit in-progress gamesget_opponenthelper method to Race struct for cleaner codeChanges
forfeit_gamefunction (lines 263-283)get_opponenthelper method (lines 235-246)Test plan
aztec test)aztec compile)🤖 Generated with Claude Code