Add consistent error handling to all TypeScript scripts#197
Open
aapsi wants to merge 1 commit intoAztecProtocol:nextfrom
Open
Add consistent error handling to all TypeScript scripts#197aapsi wants to merge 1 commit intoAztecProtocol:nextfrom
aapsi wants to merge 1 commit intoAztecProtocol:nextfrom
Conversation
- Add .catch() error handling to scripts that were missing it - Ensures all scripts fail gracefully with proper exit codes - Improves consistency across the codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary: Add Consistent Error Handling to TypeScript Scripts
Title:
Add consistent error handling to all TypeScript scriptsDescription:
This PR addresses an inconsistency in error handling across the TypeScript scripts in the repository. Previously, some scripts had proper error handling while others would crash with unhandled promise rejections.
Problem:
Solution:
Added
.catch()error handling to all scripts that were missing it, ensuring:Changes Made:
.catch()error handling to scripts that were missing itconsole.error()andprocess.exit(1)Files Changed:
scripts/deploy_account.ts- Added error handling todeployAccount()callscripts/fees.ts- Added error handling tomain()callscripts/get_block.ts- Added error handling tomain()callscripts/multiple_pxe.ts- Added error handling tomain()callscripts/profile_deploy.ts- Added error handling tomain()callBefore:
After:
Impact:
Testing:
Type of Change:
Why This Matters:
This change standardizes error handling across the entire script collection, making the codebase more professional and predictable for developers using these scripts as examples or in their own projects.