fix(p2p): avoid 32-bit overflow in attestation pool block position key#22412
Open
spypsy wants to merge 1 commit intomerge-train/spartanfrom
Open
fix(p2p): avoid 32-bit overflow in attestation pool block position key#22412spypsy wants to merge 1 commit intomerge-train/spartanfrom
spypsy wants to merge 1 commit intomerge-train/spartanfrom
Conversation
Replace bit-shift with multiplication in getBlockPositionKey to prevent 32-bit signed integer overflow on large slot numbers. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<<) with multiplication inAttestationPool.getBlockPositionKeyto prevent 32-bit signed integer overflow on large slot numbers. JavaScript's<<converts operands to signed 32-bit ints, which overflows after slot ~2^21. Using multiplication keeps values in float64 range (safe up to 2^53).Fixes A-760