fix: skip default pp in sol aggregation#20521
Open
iakovenkos wants to merge 3 commits intomerge-train/barretenbergfrom
Open
fix: skip default pp in sol aggregation#20521iakovenkos wants to merge 3 commits intomerge-train/barretenbergfrom
iakovenkos wants to merge 3 commits intomerge-train/barretenbergfrom
Conversation
iakovenkos
commented
Feb 14, 2026
Contributor
Author
There was a problem hiding this comment.
mostly the changes from regeneration
Collaborator
There was a problem hiding this comment.
I dont like that we can get so out of date
Contributor
Author
There was a problem hiding this comment.
should we uncommit these?
Collaborator
There was a problem hiding this comment.
The smallest move, if we do want to manually check these diffs, is to add a test that it gets generated the same way
iakovenkos
commented
Feb 14, 2026
| Fr recursionSeparator = generateRecursionSeparator(proof.pairingPointObject, P_0_agg, P_1_agg); | ||
| (Honk.G1Point memory P_0_other, Honk.G1Point memory P_1_other) = | ||
| convertPairingPointsToG1(proof.pairingPointObject); | ||
| // Aggregate pairing points (skip if default/infinity — no recursive verification occurred) |
iakovenkos
commented
Feb 14, 2026
| Fr recursionSeparator = generateRecursionSeparator(proof.pairingPointObject, pair.P_0, pair.P_1); | ||
| (Honk.G1Point memory P_0_other, Honk.G1Point memory P_1_other) = | ||
| convertPairingPointsToG1(proof.pairingPointObject); | ||
| // Aggregate pairing points (skip if default/infinity — no recursive verification occurred) |
iakovenkos
commented
Feb 14, 2026
| [[maybe_unused]] const auto clear_tag = OriginTag::constant(); /* A tag representing a constant value */ \ | ||
| [[maybe_unused]] const auto constant_tag = OriginTag::constant(); /* Alias for clear_tag */ \ | ||
| const auto submitted_value_origin_tag = OriginTag( \ | ||
| [[maybe_unused]] const auto submitted_value_origin_tag = OriginTag( \ |
ledwards2225
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after switching from default on-curve pp (P_0, P_1) to (0,0) sol would fail at on-curve validation step for these values, skip aggregation step if default value is provided